Skip to content

Commit f4a1bd5

Browse files
committed
Improve: Trigger grammar check when save edit. release v1.7.2
1 parent bf09cd7 commit f4a1bd5

7 files changed

Lines changed: 17 additions & 14 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
### v1.7.2
2+
- Improve: Trigger grammar check when save edit.
13
### v1.7.1
24
- Feature: Grammar check be optional features from experiment.
35

README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,21 @@
11
# Flink-SQL-Checker
22

3-
This extension provides Flink SQL support for VSCode. Support Flink SQL error grammer check, syntax highlighting, complete keywords, rename and code format, including user-defined functions.
3+
This extension provides Flink SQL support for VSCode. support Flink SQL error grammar check, syntax highlighting, complete keywords, rename and code format, including user-defined functions.
44

55

66
## 1.Features
77

88
### 1.1 Grammar Check
9-
open your `setting.json`, add `"flink-sql-grammar-check.enable": true` or
9+
open your `setting.json`, add `"flink-sql-grammar-check.enable": true` or setting like
1010
![](images/open-setting.jpg)
1111

12-
example:
13-
- ![](images/expect-semicolon.jpg)
12+
then the plugin will check grammar when you save edit (suggest you turn off automatic saving).
1413

15-
- ![](images/select-not-expect-comma.jpg)
14+
example:
1615

1716
- ![](images/unexpect-input.jpg)
17+
- ![](images/select-not-expect-comma.jpg)
18+
- ![](images/expect-semicolon.jpg)
1819

1920
### 1.2 Rename
2021
![](images/rename.gif)

out/extension.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

out/extension.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "flink-sql",
3-
"version": "1.7.1",
3+
"version": "1.7.2",
44
"displayName": "Flink SQL Checker",
55
"description": "Support Flink SQL grammar check, syntax highlighting, complete keywords, rename and code format, including user-defined functions",
66
"publisher": "CamileSing",

src/extension.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,17 +75,17 @@ function updateFeatureStatus() {
7575
// 创建诊断集合,用于报告语法错误和警告
7676
const diagnosticCollection = vscode.languages.createDiagnosticCollection(selector);
7777

78-
// 监听文件更改事件
79-
vscode.workspace.onDidChangeTextDocument((event: vscode.TextDocumentChangeEvent) => {
78+
// 保存时触发
79+
vscode.workspace.onDidSaveTextDocument((event: vscode.TextDocument) => {
8080
// 检查文件是否为Flink SQL文件
81-
if (event.document.languageId !== selector) {
81+
if (event.languageId !== selector) {
8282
return;
8383
}
8484
// 清除之前的诊断信息
8585
diagnosticCollection.clear();
8686

8787
// 使用生成的词法分析器和解析器进行语法检查
88-
const inputStream = new ANTLRInputStream(event.document.getText());
88+
const inputStream = new ANTLRInputStream(event.getText());
8989
const lexer = new FlinkSQLLexer(inputStream);
9090
const tokenStream = new CommonTokenStream(lexer);
9191
const parser = new FlinkSQLParser(tokenStream);

0 commit comments

Comments
 (0)