Skip to content

Commit a77c19b

Browse files
committed
ci: hardcode App ID on central workflow
Although I would have preferred to keep this a secret, since the application is private to our organization, I decided to hardcode the App ID on the central workflow to avoid having to manage another secret on all repos besides the private key of the app. This way, in the eventuality that we need to redo the app, we won't need to change both secrets on all the repositories, so we cut the maintenance in half.
1 parent f9373fb commit a77c19b

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

.github/workflows/pr-issues-project.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ name: "pr-issues-project"
1010
on:
1111
workflow_call:
1212
secrets:
13-
PROJECT_APP_ID:
14-
description: "GitHub App ID for the DevOps Stack Project app"
15-
required: true
1613
PROJECT_APP_PRIVATE_KEY:
1714
description: "GitHub App private key for the DevOps Stack Project app"
1815
required: true
@@ -35,7 +32,7 @@ jobs:
3532
id: generate_token
3633
uses: tibdex/github-app-token@v1
3734
with:
38-
app_id: ${{ secrets.PROJECT_APP_ID }}
35+
app_id: 322306
3936
private_key: ${{ secrets.PROJECT_APP_PRIVATE_KEY }}
4037

4138
- name: Add PR or issue to DevOps Stack project board

0 commit comments

Comments
 (0)