feat: scaffold GARM 12-factor charm with ROCK image (ISD-5718)#208
Draft
yanksyoon wants to merge 9 commits into
Draft
feat: scaffold GARM 12-factor charm with ROCK image (ISD-5718)#208yanksyoon wants to merge 9 commits into
yanksyoon wants to merge 9 commits into
Conversation
Builds GARM v0.2.1 and garm-provider-openstack v0.1.5 from source. Version tags are annotated for Renovate to track GitHub releases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Use ./cmd/garm (not ./cmd/garm-server) as the main package path - Add osusergo,netgo,sqlite_omit_load_extension build tags so the statically-linked binary works inside the bare base image Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add lib/ to PYTHONPATH in tox.toml (needed when charm libraries are vendored) - Add .gitignore copied from planner-operator - Add tests/unit/.gitkeep so the directory is tracked by git Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove forward reference to undefined GarmCharm (fixes F821) - Add comments for scaffold placeholder values in provider config - Use Python version marker for tomli test dep Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- _ensure_secrets() creates jwt-secret and db-passphrase on first install - restart() pushes TOML config and overrides Pebble command before replan - _generate_garm_secrets() produces 64-char hex tokens Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Catch SecretNotFoundError in restart() and set WaitingStatus - Remove redundant can_connect() check (is_ready() already verifies) - Add TODO comment documenting the double-replan issue (ISD-5718) - Add clarifying comment for db-passphrase placeholder - Add pythonpath to pyproject.toml for IDE/direct pytest support Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
garm-rockcraft.yamlandbuild-garm-rock.sh: ROCK image building GARM v0.2.1 and garm-provider-openstack v0.1.5 from source, with SQLite build tags for bare basecharms/garm-operator/: 12-factor charm scaffold extendingpaas_charm.go.Charm, renders GARM TOML config on every reconcile, stores JWT secret and DB passphrase in Juju secretscharms/garm-operator/terraform/: Terraform module for deploying the charm via Juju providerTest Plan
tox -e lintpassestox -e staticpassestox -e unitpasses (7 tests)build-garm-rock.shNotes
/metricsendpoint withdisable_auth=true