Skip to content

Commit a33783d

Browse files
authored
Merge pull request #360 from carpentries-incubator/anenadic-failed-builds
Added callout about failed builds
2 parents 40d25c6 + be257ad commit a33783d

2 files changed

Lines changed: 23 additions & 2 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,11 @@ This indicates that the maintainers will welcome pull requests fixing such issue
6969

7070
Current maintainers of this lesson (in alphabetical order) are:
7171

72-
* [Matthew Bluteau][matthew-bluteau]
72+
* [Matthew Bluteau][matthew-bluteau] - Lead Maintainer for the period 1 May 2024 - 31 October 2024
7373
* [Steve Crouch][steve-crouch]
7474
* [Kamilla Kopec-Harding][kamilla-kopec-harding]
7575
* [Doug Lowe][doug-lowe]
76-
* [Aleksandra Nenadic][aleksandra-nenadic] (lead Maintainer for the period 1 October 2023 - 31 March 2024)
76+
* [Aleksandra Nenadic][aleksandra-nenadic]
7777

7878
The maintainer team aims to meet at 11:00 UK time (BST or GMT) on the fourth Wednesday each month. The meetings alternate between operations meetings and co-working sprints.
7979
Meeting notes are kept in the [Google doc](https://docs.google.com/document/d/1-SvoY_2GvlQgJnu8zfr6VnU7sev_iWZAIwBUywNSfWE/edit#).

_episodes/23-continuous-integration-automated-testing.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -421,4 +421,25 @@ which potentially saves us a lot of time waiting for testing results.
421421
Overall, this approach allows us to massively scale our automated testing
422422
across platforms we wish to test.
423423

424+
> ## Failed CI Builds
425+
> A CI build can fail when, e.g. a used Python package no longer supports a particular version of
426+
> Python indicated in a GitHub Actions CI build matrix. In this case, the solution is either to
427+
> upgrade the Python version in the build matrix (when possible) or downgrade the package version (and not use the latest one like we have been doing in this course).
428+
>
429+
> Also note that, if one job fails in the build for any reason - all subsequent jobs will get cancelled because of the default behavior of
430+
> GitHub Actions. From [GitHub's documentation](https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures):
431+
>
432+
> >*"GitHub will cancel all in-progress and queued jobs in the matrix if any job in the matrix fails."*
433+
>
434+
> This behaviour can be controlled by changing the value of the `fail-fast` property:
435+
> ~~~
436+
> ...
437+
> strategy:
438+
> fail-fast: false
439+
> matrix:
440+
> ...
441+
> ~~~
442+
{: .language-yaml}
443+
{: .callout}
444+
424445
{% include links.md %}

0 commit comments

Comments
 (0)