add confirmation step before deleting tx from Lunch Money

Author: casidiablo

handlers/transactions.py

@@ -388,6 +388,26 @@ async def handle_btn_skip_transaction(update: Update, _: ContextTypes.DEFAULT_TY
     )
 
 
+async def handle_btn_confirm_delete_transaction(update: Update, _: ContextTypes.DEFAULT_TYPE):
+    """Show a confirmation keyboard before actually deleting the transaction."""
+    query = update.callback_query
+    if query is None:
+        return
+
+    tx_id = int(update.callback_data_suffix)
+    kbd = Keyboard()
+    kbd += ("✅ Yes, delete from Telegram and Lunch Money", f"deleteTx_{tx_id}")
+    kbd += ("❌ Cancel", f"cancelDeleteTx_{tx_id}")
+    await query.answer()
+    await update.safe_edit_message_reply_markup(reply_markup=kbd.build(columns=1))
+
+
+async def handle_btn_cancel_delete_transaction(update: Update, _: ContextTypes.DEFAULT_TYPE):
+    """Restore the normal expanded keyboard after the user cancels deletion."""
+    tx_id = int(update.callback_data_suffix)
+    await update.safe_edit_message_reply_markup(reply_markup=get_tx_buttons(update.chat_id, tx_id, collapsed=False))
+
+
 async def handle_btn_delete_transaction(update: Update, _: ContextTypes.DEFAULT_TYPE):
     query = update.callback_query
     if query is None:

main.py

@@ -79,8 +79,10 @@
     handle_btn_ai_categorize,
     handle_btn_apply_category,
     handle_btn_cancel_categorization,
+    handle_btn_cancel_delete_transaction,
     handle_btn_close_plaid_details,
     handle_btn_collapse_transaction,
+    handle_btn_confirm_delete_transaction,
     handle_btn_delete_transaction,
     handle_btn_dump_plaid_details,
     handle_btn_mark_tx_as_reviewed,
@@ -186,6 +188,8 @@ def add_settings_callback_query_handlers(app):
 def add_application_callback_query_handlers(app):
     # Transaction handlers
     app.add_handler(CallbackQueryHandler(handle_btn_skip_transaction, pattern=r"^skip_"))
+    app.add_handler(CallbackQueryHandler(handle_btn_confirm_delete_transaction, pattern=r"^confirmDeleteTx_"))
+    app.add_handler(CallbackQueryHandler(handle_btn_cancel_delete_transaction, pattern=r"^cancelDeleteTx_"))
     app.add_handler(CallbackQueryHandler(handle_btn_delete_transaction, pattern=r"^deleteTx_"))
     app.add_handler(CallbackQueryHandler(handle_btn_collapse_transaction, pattern=r"^collapse_"))
     app.add_handler(CallbackQueryHandler(handle_btn_cancel_categorization, pattern=r"^cancelCategorization_"))

tx_messaging.py

@@ -48,7 +48,7 @@ def _add_expanded_buttons(
         kbd += ("Skip", f"skip_{transaction_id}")
 
     if sync_delete:
-        kbd += ("🗑️ Delete", f"deleteTx_{transaction_id}")
+        kbd += ("🗑️ Delete", f"confirmDeleteTx_{transaction_id}")
 
     if is_reviewed:
         kbd += ("Unreview", f"unreview_{transaction_id}")