Skip to content

Commit 62782db

Browse files
benedikt-voelkelBenedikt Volkel
andauthored
[RelVal] Add specific QC objects to compare (AliceO2Group#1458)
* put files with include patterns at RelVal/config/QC/async/<DET>_include_patterns_default.txt * add pattern files for ITS, TPC, TOF * allow comments starting with "#" Co-authored-by: Benedikt Volkel <benedikt.volkel@cern.ch>
1 parent 4585247 commit 62782db

4 files changed

Lines changed: 46 additions & 1 deletion

File tree

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# for data and MC
2+
ITS_Tracks_PhiDistribution$
3+
ITS_Tracks_NClusters$
4+
ITS_Tracks_VertexZ$
5+
ITS_Tracks_VertexRvsZ$
6+
ITS_Tracks_VertexCoordinates$
7+
ITS_Clusters_Layer0_AverageClusterSizeSummary$
8+
ITS_Clusters_Layer3_AverageClusterSizeSummary$
9+
# only MC
10+
ITS_TracksMc_efficiency_eta_ratioFromTEfficiency$
11+
ITS_TracksMc_efficiency_phi_ratioFromTEfficiency$
12+
ITS_TracksMc_efficiency_pt_ratioFromTEfficiency$
13+
ITS_TracksMc_faketrack_eta_ratioFromTEfficiency$
14+
ITS_TracksMc_faketrack_phi_ratioFromTEfficiency$
15+
ITS_TracksMc_faketrack_pt_ratioFromTEfficiency$
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# note that all "/" have to be replaced by "_"
2+
TOF_Digits_DecodingErrors$
3+
TOF_Digits_Multiplicity_Integrated$
4+
TOF_MatchTrAll_mTOFChi2ITSTPC-ITSTPCTRD$
5+
TOF_MatchTrAll_mTOFChi2TPC$
6+
TOF_MatchTrAll_mTOFChi2TPCTRD$
7+
TOF_MatchTrAll_mEffPt_ITSTPC-ITSTPCTRD_ratioFromTEfficiency$
8+
TOF_PID_EvTimeTOF$
9+
TOF_PID_DeltaBCTOFFT0$
10+
TOF_PID_DeltatPi_Pt_ITSTPC_t0TOF$
11+
TOF_PID_DeltatPi_Pt_ITSTPCTRD_t0TOF$
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# note that all "/" have to be replaced by "_"
2+
TPC_Tracks_hPhiAside$
3+
TPC_Tracks_hPhiCside$
4+
TPC_Tracks_hEta$
5+
TPC_Tracks_hNClustersAfterCuts$
6+
TPC_Tracks_hQOverPt$
7+
TPC_Tracks_hDCAr_A_Pos$
8+
TPC_Tracks_hDCAr_C_Pos$
9+
TPC_Tracks_hDCArVsEtaPos$
10+
TPC_Tracks_h2DNClustersPhiAside$
11+
TPC_Tracks_h2DNClustersPhiCside$
12+
TPC_PID_hdEdxTotMIP_TPC$
13+
TPC_PID_hdEdxTotVsP_TPC$

RelVal/utils/o2dpg_release_validation_utils.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,9 +282,15 @@ def load_this_patterns(patterns):
282282
return patterns
283283

284284
patterns_from_file = []
285-
with open(patterns[0][1:], "r") as f:
285+
filename = patterns[0][1:]
286+
if not exists(filename):
287+
print(f"WARNING: Pattern file {filename} does not exist, not extracting any patterns!")
288+
return
289+
with open(filename, "r") as f:
286290
for line in f:
287291
line = line.strip()
292+
# remove all comments; allows for inline comments or entire comment lines), then take the first token
293+
line = line.split("#")[0].strip()
288294
if not line:
289295
continue
290296
patterns_from_file.append(line)

0 commit comments

Comments
 (0)