Call archive_write_finish_entry after extraction to close file handle

cataphract · claude · cataphract · commit 2b1043955dc7 · 2026-03-10T11:29:51.000Z
Without this, arch_disk holds the extracted file open until the Archive
object is destroyed. On Windows this blocks unlink() since object
destructors run after register_shutdown_function callbacks.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/libarchive.c b/libarchive.c
@@ -334,6 +334,13 @@ PHP_METHOD(libarchive_Archive, extractCurrent)
     if (!copy_data(arch_obj->archive, arch_obj->arch_disk)) {
         return;
     }
+
+    res = archive_write_finish_entry(arch_obj->arch_disk);
+    if (res != ARCHIVE_OK) {
+        zend_throw_exception_ex(except_ce, archive_errno(arch_obj->arch_disk),
+                                "Could not finish writing entry: %s",
+                                archive_error_string(arch_obj->arch_disk));
+    }
 }
 
 static bool copy_data(struct archive *ar, struct archive *aw)

Original file line number	Diff line number	Diff line change
`@@ -334,6 +334,13 @@ PHP_METHOD(libarchive_Archive, extractCurrent)`
`334`	`334`	`if (!copy_data(arch_obj->archive, arch_obj->arch_disk)) {`
`335`	`335`	`return;`
`336`	`336`	`}`
	`337`	`+`
	`338`	`+ res = archive_write_finish_entry(arch_obj->arch_disk);`
	`339`	`+ if (res != ARCHIVE_OK) {`
	`340`	`+ zend_throw_exception_ex(except_ce, archive_errno(arch_obj->arch_disk),`
	`341`	`+ "Could not finish writing entry: %s",`
	`342`	`+ archive_error_string(arch_obj->arch_disk));`
	`343`	`+ }`
`337`	`344`	`}`
`338`	`345`
`339`	`346`	`static bool copy_data(struct archive ar, struct archive aw)`