Skip to content

Audit recent Codex Lab PRs against authoritative Every Code source #126

@shiny-code-bot

Description

@shiny-code-bot

Finish Line

Recent Codex Lab PRs that were intended to port Every Code features or fixtures are audited against the authoritative restored Every Code source at ../code-prealign-new-skills/code-rs, with each affected slice classified as keep, fix, rework, quarantine, or revert before more feature work builds on it.

Current Status

Active parity audit remains paused at PR #63, after fixing the PR #60/#128 follow-up regressions.

Completed since the prior status:

Validation for #129:

  • cargo fmt --manifest-path codex-rs/Cargo.toml --all --check
  • git diff --check
  • cargo test -p codex-auto-review
  • cargo test -p codex-core auto_review_awareness
  • Read-only agent reviews iterated through migration compatibility, hot-path awareness detection, and legacy/new precedence issues before merge.
  • PR Fix auto-review store migration awareness #129 CI passed and was merged; local main is fast-forwarded.

Current stop point:

  • PR Persist detached review runs #63 (native-detached-auto-review-runtime) is still the first credible possible parity miss from the low-to-high audit.
  • The open question is whether Codex Lab should replace its simplified detached auto-review persistence/lifecycle model with the richer authoritative Every Code review store/coordination model before continuing the audit.

Next action:

Audit Tracks

P0: Auth, login, and account switching

First queue: PRs #116, #117, #118, #119, #120, #122, #123, #124.

Authoritative source areas:

  • ../code-prealign-new-skills/code-rs/core/src/auth.rs
  • ../code-prealign-new-skills/code-rs/core/src/auth_accounts.rs
  • ../code-prealign-new-skills/code-rs/core/src/account_switching.rs
  • ../code-prealign-new-skills/code-rs/core/src/account_usage.rs
  • ../code-prealign-new-skills/code-rs/login/src/server.rs
  • ../code-prealign-new-skills/code-rs/login/src/device_code_auth.rs
  • ../code-prealign-new-skills/code-rs/tui/src/bottom_pane/login_accounts_view.rs
  • ../code-prealign-new-skills/code-rs/tui/src/bottom_pane/account_switch_settings_view.rs
  • ../code-prealign-new-skills/code-rs/tui/src/account_label.rs
  • ../code-prealign-new-skills/code-rs/tui/src/onboarding/auth.rs

Immediate audit question: does Codex Lab's /login and add-account flow match Every Code's flow where selecting Add opens the auth webpage, rather than sending the user to another command?

P0: Browser, bridge, and app-server client behavior

First queue: PRs #88, #89, #90, #100 through #112, plus #36-related work.

Authoritative source areas:

  • ../code-prealign-new-skills/code-rs/cli/src/bridge.rs
  • ../code-prealign-new-skills/code-rs/core/src/bridge_client.rs
  • ../code-prealign-new-skills/code-rs/browser/src/config.rs
  • ../code-prealign-new-skills/code-rs/browser/src/hooks/browser_injector.rs
  • ../code-prealign-new-skills/code-rs/browser/src/tools/browser_tools.rs
  • ../code-prealign-new-skills/code-rs/browser/src/page.rs
  • ../code-prealign-new-skills/code-rs/tui/src/chatwidget/browser_sessions.rs
  • ../code-prealign-new-skills/code-rs/tui/src/history_cell/browser.rs

Immediate audit question: which bridge/browser behavior is actual Every Code parity, and which Codex Lab work is useful but product-original and should be tracked as such?

P1: External agents, session provenance, and worktrees

First queue: PRs #82, #86, #92, #94, #95, #96, #97.

Authoritative source areas:

  • ../code-prealign-new-skills/code-rs/core/src/agent_tool.rs
  • ../code-prealign-new-skills/code-rs/core/src/agent_defaults.rs
  • ../code-prealign-new-skills/code-rs/core/src/external_agent_config.rs
  • ../code-prealign-new-skills/code-rs/app-server/src/external_agent_config_api.rs
  • ../code-prealign-new-skills/code-rs/tui/src/bottom_pane/agents_settings_view.rs
  • ../code-prealign-new-skills/code-rs/tui/src/bottom_pane/agents_overview_view.rs
  • ../code-prealign-new-skills/code-rs/tui/src/bottom_pane/agent_editor_view.rs
  • ../code-prealign-new-skills/code-rs/tui/src/chatwidget/agent_runs.rs

P1: Home/config migration and repository-local state

First queue: PRs #84, #87, #91, #114, plus config/home pieces inside auth PRs.

Authoritative source areas:

  • ../code-prealign-new-skills/code-rs/core/src/config.rs
  • ../code-prealign-new-skills/code-rs/core/src/config_types.rs
  • ../code-prealign-new-skills/code-rs/core/src/config_edit.rs
  • ../code-prealign-new-skills/code-rs/common/src
  • ../code-prealign-new-skills/code-rs/cli/src/main.rs
  • ../code-prealign-new-skills/code-rs/exec/src/cli.rs

P2: Exec harness, snapshots, and fixtures

First queue: PRs #40, #44, #75, and any fixtures created to prove bridge/auth behavior.

Authoritative source areas:

  • ../code-prealign-new-skills/code-rs/core/src/patch_harness.rs
  • ../code-prealign-new-skills/code-rs/exec/src/cli.rs
  • ../code-prealign-new-skills/code-rs/exec/src/main.rs
  • ../code-prealign-new-skills/code-rs/tui/tests/vt100_chatwidget_snapshot.rs
  • ../code-prealign-new-skills/code-rs/tui/tests/snapshots/
  • ../code-prealign-new-skills/code-rs/app-server-protocol/tests/schema_fixtures.rs
  • ../code-prealign-new-skills/code-rs/app-server-protocol/schema/

Audit Template

For each PR or feature slice, record:

  • PR / feature slice.
  • Intended Every Code behavior.
  • Authoritative Every Code source files inspected.
  • Codex Lab files inspected.
  • Match verdict: matches, diverges, no Every Code equivalent, or unclear.
  • Product verdict: keep, fix, rework, quarantine, or revert.
  • Validation needed: static source comparison, fixture, snapshot, live dogfood, or CI only.
  • Follow-up issue or PR required.

Validation Guardrails

  • Use static source comparison and offline fixtures first.
  • Use live dogfood only for behavior that cannot be safely mocked, such as real auth browser handoff or real bridge lifecycle.
  • Do not run automated loops against live auth/model accounts; protect weekly quotas and prompt-cache locality.
  • For TUI changes, prefer snapshot or screenshot evidence compared against the authoritative Every Code UX.
  • For auth/config tests, override home directories and never mutate the user's real home in automation.

Relationships

Acceptance Criteria

  • A full merged-PR inventory exists from the lowest merged PR number through the current head.
  • Each PR is classified as Every Code parity, Codex Lab original, infrastructure, docs/planning, or unknown.
  • Parity and unknown PRs have an audit verdict against ../code-prealign-new-skills/code-rs: keep, fix, rework, quarantine, revert, or needs decision.
  • The audit proceeds read-only unless the user explicitly approves corrective implementation.
  • The auditor stops at each credible possible miss and reports both the suspected miss and a short list of items that looked correct so far.

Metadata

Metadata

Assignees

No one assigned

    Labels

    planDurable planning issueplan:activePlan is actionable now

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions