Expect an empty array for account balances

nilsenpaul · web-flow · commit 0d4bd410450f · 2020-09-15T11:51:26.000+02:00
With a new Binance account, the API returns an empty array for the `balances`. This causes some misleading error messages to be shown, saying things about `useServerTime()` and faulty credentials.
diff --git a/php-binance-api.php b/php-binance-api.php
@@ -832,8 +832,9 @@ public function balances($priceData = false)
             echo "Error: unable to fetch your account details" . PHP_EOL;
         }
 
-        if (isset($account['balances']) === false) {
+        if (isset($account['balances']) === false || empty($account['balances'])) {
             echo "Error: your balances were empty or unset" . PHP_EOL;
+	    return [];
         }
 
         return $this->balanceData($account, $priceData);

Original file line number	Diff line number	Diff line change
`@@ -832,8 +832,9 @@ public function balances($priceData = false)`
`832`	`832`	`echo "Error: unable to fetch your account details" . PHP_EOL;`
`833`	`833`	`}`
`834`	`834`
`835`		`- if (isset($account['balances']) === false) {`
	`835`	`+ if (isset($account['balances']) === false \|\| empty($account['balances'])) {`
`836`	`836`	`echo "Error: your balances were empty or unset" . PHP_EOL;`
	`837`	`+ return [];`
`837`	`838`	`}`
`838`	`839`
`839`	`840`	`return $this->balanceData($account, $priceData);`