Update php-binance-api.php

afsharsafavi · web-flow · commit 80125c8ac386 · 2019-01-18T14:49:17.000+03:30
Hello I found a bug in httpRequest method that causes error 400. It seems there is a bug that cause on some servers below error: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> <HTML><HEAD><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1"> <TITLE>ERROR: The request could not be satisfied</TITLE> </HEAD><BODY> <H1>400 ERROR</H1> <H2>The request could not be satisfied.</H2> <HR noshade size="1px"> Bad request. <BR clear="all"> <HR noshade size="1px"> <PRE> Generated by cloudfront (CloudFront) Request ID: t5MiwWw_1St1zze5JTgwkAqVnPDc_d5ZFkGSRlYm_pK7qL8lL6izhA== </PRE> <ADDRESS> </ADDRESS> </BODY></HTML> I received this error on my server in Netherlands and with the same code, it's OK on my Germany server. It seems this error occur when httrequest method is POST. You should send your data (like order parameters) in post fields, not in url query. By the way, I edited httpRequest method and now it's work fine. I think that I solved this issue: #99
diff --git a/php-binance-api.php b/php-binance-api.php
@@ -876,7 +876,10 @@ private function httpRequest(string $url, string $method = "GET", array $params
             }
             $query = http_build_query($params, '', '&');
             $signature = hash_hmac('sha256', $query, $this->api_secret);
-            $endpoint = $base . $url . '?' . $query . '&signature=' . $signature;
+			if ($method === "POST") {
+				$endpoint = $base . $url . '?'  . 'signature=' . $signature;
+			} else
+				$endpoint = $base . $url . '?' . $query . '&signature=' . $signature;
             curl_setopt($curl, CURLOPT_URL, $endpoint);
             curl_setopt($curl, CURLOPT_HTTPHEADER, array(
                 'X-MBX-APIKEY: ' . $this->api_key,
@@ -897,7 +900,7 @@ private function httpRequest(string $url, string $method = "GET", array $params
         // Post and postfields
         if ($method === "POST") {
             curl_setopt($curl, CURLOPT_POST, true);
-            // curl_setopt($curlch, CURLOPT_POSTFIELDS, $query);
+            curl_setopt($curlch, CURLOPT_POSTFIELDS, $query);
         }
         // Delete Method
         if ($method === "DELETE") {
