Skip to content

Commit dd1950f

Browse files
authored
Remove obsolete project generator tests (#269)
* Remove outdated unit tests * Update GH workflow tests
1 parent 367288e commit dd1950f

7 files changed

Lines changed: 14 additions & 330 deletions

File tree

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ jobs:
3636
- 21
3737
test-class:
3838
- 'io.github.cdsap.projectgenerator.ProjectGeneratorE2ETest'
39-
- 'io.github.cdsap.projectgenerator.ProjectGeneratorE2EAgp9Test'
4039
- 'io.github.cdsap.projectgenerator.ProjectGeneratorE2EJdk21Test'
41-
- 'io.github.cdsap.projectgenerator.SingleE2EValidationTest'
40+
- 'io.github.cdsap.projectgenerator.RoomDiVariantsAssembleE2EValidationTest'
41+
- 'io.github.cdsap.projectgenerator.AndroidKotlinMultiplatformLibraryE2EValidationTest'
4242
runs-on: ubuntu-latest
4343
timeout-minutes: 60
4444
needs: unit-tests

project-generator/src/test/kotlin/io/github/cdsap/projectgenerator/ProjectGeneratorE2EAgp9Test.kt

Lines changed: 0 additions & 76 deletions
This file was deleted.

project-generator/src/test/kotlin/io/github/cdsap/projectgenerator/RoomDiVariantsAssembleE2EValidationTest.kt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,5 +57,13 @@ class RoomDiVariantsAssembleE2EValidationTest {
5757
assertTrue(assemble.output.contains("BUILD SUCCESSFUL"))
5858
assertTrue(assemble.output.contains("assembleDebug"))
5959
assertTrue(assemble.output.contains("assembleRelease"))
60+
61+
if (di == DependencyInjection.NONE) {
62+
val tests = GradleRunner.create()
63+
.withProjectDir(projectDir)
64+
.withArguments("testDebugUnitTest")
65+
.build()
66+
assertTrue(tests.output.contains("BUILD SUCCESSFUL"))
67+
}
6068
}
6169
}

project-generator/src/test/kotlin/io/github/cdsap/projectgenerator/RoomManifestGenerationTest.kt

Lines changed: 0 additions & 60 deletions
This file was deleted.

project-generator/src/test/kotlin/io/github/cdsap/projectgenerator/RoomNoneE2EValidationTest.kt

Lines changed: 0 additions & 62 deletions
This file was deleted.

project-generator/src/test/kotlin/io/github/cdsap/projectgenerator/SingleE2EValidationTest.kt

Lines changed: 0 additions & 127 deletions
This file was deleted.
Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.github.cdsap.projectgenerator.generator.planner
22

33
import io.github.cdsap.projectgenerator.model.ClassTypeAndroid
4+
import io.github.cdsap.projectgenerator.model.ClassesPerModule
45
import io.github.cdsap.projectgenerator.model.ProjectGraph
56
import io.github.cdsap.projectgenerator.model.TypeProject
67
import org.junit.jupiter.api.Assertions.assertEquals
@@ -10,14 +11,14 @@ import org.junit.jupiter.api.Test
1011
class ModuleClassPlannerAndroidTest {
1112

1213
@Test
13-
fun `app module with low class count still includes activity and baseline classes`() {
14+
fun `app module at minimum class count includes activity and baseline classes`() {
1415
val planner = ModuleClassPlannerAndroid()
1516
val module = ProjectGraph(
1617
id = "module_2_9",
1718
layer = 2,
1819
nodes = emptyList(),
1920
type = TypeProject.ANDROID_APP,
20-
classes = 5
21+
classes = ClassesPerModule.MIN_CLASSES_PER_MODULE
2122
)
2223

2324
val result = planner.planModuleClasses(module)
@@ -26,6 +27,6 @@ class ModuleClassPlannerAndroidTest {
2627
assertTrue(types.contains(ClassTypeAndroid.ACTIVITY))
2728
assertTrue(types.contains(ClassTypeAndroid.SCREEN))
2829
assertTrue(types.contains(ClassTypeAndroid.VIEWMODEL))
29-
assertEquals(10, result.classes.size)
30+
assertEquals(ClassesPerModule.MIN_CLASSES_PER_MODULE, result.classes.size)
3031
}
3132
}

0 commit comments

Comments
 (0)