Bubble up missing flag errors

cdvel · cdvel · commit a3b888244d4e · 2021-03-30T13:08:59.000+08:00
diff --git a/cmd/checksum.go b/cmd/checksum.go
@@ -37,11 +37,9 @@ func GetChecksum(value []byte, hashFn string) string {
 func ChecksumRun(cmd *cobra.Command, args []string) error {
 
 	filename, _ := cmd.Flags().GetString("file")
-
 	fs := File(filename).CheckFile()
 
 	if fs.Err != nil {
-		fmt.Println(fs.Err)
 		return fs.Err
 	} else {
 
@@ -58,6 +56,10 @@ func ChecksumRun(cmd *cobra.Command, args []string) error {
 			}
 		}
 
+		if algorithmFlag == "" {
+			return fmt.Errorf("Checksum flag is missing. One of md5, sha1, sha256 is required.")
+		}
+
 		fmt.Println(GetChecksum(contents, algorithmFlag))
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -37,11 +37,9 @@ func GetChecksum(value []byte, hashFn string) string {`
`37`	`37`	`func ChecksumRun(cmd *cobra.Command, args []string) error {`
`38`	`38`
`39`	`39`	`filename, _ := cmd.Flags().GetString("file")`
`40`		`-`
`41`	`40`	`fs := File(filename).CheckFile()`
`42`	`41`
`43`	`42`	`if fs.Err != nil {`
`44`		`- fmt.Println(fs.Err)`
`45`	`43`	`return fs.Err`
`46`	`44`	`} else {`
`47`	`45`
`@@ -58,6 +56,10 @@ func ChecksumRun(cmd *cobra.Command, args []string) error {`
`58`	`56`	`}`
`59`	`57`	`}`
`60`	`58`
	`59`	`+ if algorithmFlag == "" {`
	`60`	`+ return fmt.Errorf("Checksum flag is missing. One of md5, sha1, sha256 is required.")`
	`61`	`+ }`
	`62`	`+`
`61`	`63`	`fmt.Println(GetChecksum(contents, algorithmFlag))`
`62`	`64`	`}`
`63`	`65`