From f16dc71ec19d6bd470facc14f0edae519815210d Mon Sep 17 00:00:00 2001 From: Zack Cerza Date: Fri, 5 Jun 2026 17:15:15 -0600 Subject: [PATCH] Improve runtime fix Signed-off-by: Zack Cerza --- ceph_devstack/requirements.py | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/ceph_devstack/requirements.py b/ceph_devstack/requirements.py index b91946a5..9e07dbdb 100644 --- a/ceph_devstack/requirements.py +++ b/ceph_devstack/requirements.py @@ -1,6 +1,5 @@ import shlex -from pathlib import Path from packaging.version import parse as parse_version, Version from typing import List @@ -161,7 +160,9 @@ async def check(self): return True -class PodmanRuntime(Requirement): +class PodmanRuntime(FixableRequirement): + suggest_msg = "Could not find the 'crun' container runtime" + @property def fix_cmd(self): if self.host.os_type != "darwin": @@ -170,19 +171,8 @@ def fix_cmd(self): async def check(self): podman_info = await self.host.podman_info() - storage_conf_path = podman_info["store"]["configFile"] runtime = podman_info["host"]["ociRuntime"]["name"] - if runtime == "crun": - return True - else: - containers_conf_path = Path(storage_conf_path).parent / "containers.conf" - cmd = host.cmd(["podman", "system", "reset"]) - logger.error( - f"The configured runtime is '{runtime}'. " - f"It must be set to 'crun' in {containers_conf_path}. " - f"Afterward, run '{cmd}'." - ) - return False + return runtime == "crun" class SELinuxBoolean(FixableRequirement):