Merge pull request #1 from charphq/fix/match-count-logic

ianchanning · web-flow · commit ea7b3d9ddcac · 2024-06-05T17:21:28.000+02:00
Change argument order for add/remove match exist check
diff --git a/lib/bus.js b/lib/bus.js
@@ -483,7 +483,7 @@ class MessageBus extends EventEmitter {
   }
 
   _addMatch (match) {
-    if (Object.prototype.hasOwnProperty.call(match, this._matchRules)) {
+    if (Object.prototype.hasOwnProperty.call(this._matchRules, match)) {
       this._matchRules[match] += 1;
       return Promise.resolve();
     }
@@ -507,7 +507,7 @@ class MessageBus extends EventEmitter {
       return Promise.resolve();
     }
 
-    if (Object.prototype.hasOwnProperty.call(match, this._matchRules)) {
+    if (Object.prototype.hasOwnProperty.call(this._matchRules, match)) {
       this._matchRules[match] -= 1;
       if (this._matchRules[match] > 0) {
         return Promise.resolve();

Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,7 @@ class MessageBus extends EventEmitter {`
`483`	`483`	`}`
`484`	`484`
`485`	`485`	`_addMatch (match) {`
`486`		`- if (Object.prototype.hasOwnProperty.call(match, this._matchRules)) {`
	`486`	`+ if (Object.prototype.hasOwnProperty.call(this._matchRules, match)) {`
`487`	`487`	`this._matchRules[match] += 1;`
`488`	`488`	`return Promise.resolve();`
`489`	`489`	`}`
`@@ -507,7 +507,7 @@ class MessageBus extends EventEmitter {`
`507`	`507`	`return Promise.resolve();`
`508`	`508`	`}`
`509`	`509`
`510`		`- if (Object.prototype.hasOwnProperty.call(match, this._matchRules)) {`
	`510`	`+ if (Object.prototype.hasOwnProperty.call(this._matchRules, match)) {`
`511`	`511`	`this._matchRules[match] -= 1;`
`512`	`512`	`if (this._matchRules[match] > 0) {`
`513`	`513`	`return Promise.resolve();`