close #27

Author: rodber

src/Arguments.php

@@ -279,24 +279,22 @@ private function handleDefaultNested(
 
     private function assertArgumentCount(): void
     {
-        if ($this->parameters()->requiredKeys()->count() <= $this->count) {
+        $requiredKeys = $this->parameters()->requiredKeys()->toArray();
+        if (count($requiredKeys) <= $this->count) {
             return;
         }
         $argumentKeys = array_keys($this->arguments);
         if ($this->isPositional) {
             $missing = array_diff(
-                array_keys($this->parameters()->keys()),
+                array_keys($requiredKeys),
                 $argumentKeys
             );
             $missing = array_map(
-                fn (int $key) => $this->parameters()->keys()[$key],
+                fn (int $key) => $requiredKeys[$key],
                 $missing
             );
         } else {
-            $missing = array_diff(
-                $this->parameters()->keys(),
-                $argumentKeys
-            );
+            $missing = array_diff($requiredKeys, $argumentKeys);
         }
 
         throw new ArgumentCountError(

tests/ParametersTest.php

@@ -13,6 +13,7 @@
 
 namespace Chevere\Tests;
 
+use ArgumentCountError;
 use BadMethodCallException;
 use Chevere\Parameter\ArrayParameter;
 use Chevere\Parameter\BoolParameter;
@@ -110,6 +111,19 @@ public function testOptionalMissing(): void
         $parameters->optional('foo');
     }
 
+    public function testRequiredMissingNoOptional(): void
+    {
+        $parameters = (new Parameters(foo: string()))
+            ->withOptional('bar', string());
+        $this->expectException(ArgumentCountError::class);
+        $this->expectExceptionMessage(
+            <<<PLAIN
+            Missing required argument(s): `foo`
+            PLAIN
+        );
+        $parameters();
+    }
+
     public function testRequiredCasting(): void
     {
         $parameter = string();