Add explicit stm32f746g-disco Renode CI test with better diagnostics and timeouts

- Rename test-renode → test-renode-stm32f746g-disco in build.yml so the
  board under test is unambiguous; add artifact upload of Renode logs on
  failure for post-mortem debugging
- Increase CONNECT_TIMEOUT 90→120s and MONITOR_TIMEOUT 30→60s in
  run_renode_tests.sh to allow enough time for the full driver init
  sequence (dmdevfs loading dmgpio) to complete
- Add trap cleanup EXIT to kill background Renode/monitor-gdb processes
- Print connect.log tail on every run for easier CI diagnostics
- Add "Heap initialized" as a second required pattern in expected_logs.txt
  (printed early in main(), before mount_embedded_filesystems()); if the
  firmware crashes during driver init, neither message will appear and the
  test fails — this is exactly the crash path from the issue
- Update expected_logs.txt comment block to document the test rationale

Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>

Author: Copilot

.github/workflows/build.yml

@@ -139,8 +139,8 @@ jobs:
           build/dmboot.map
         retention-days: 30
 
-  test-renode:
-    name: Test Renode Simulation
+  test-renode-stm32f746g-disco:
+    name: Renode emulation test (stm32f746g-disco)
     runs-on: ubuntu-latest
     container:
       image: chocotechnologies/dmboot:1.0.0
@@ -165,14 +165,24 @@ jobs:
         git submodule init
         git submodule update --recursive
     
-    - name: Run Renode emulation tests
+    - name: Run Renode emulation tests (stm32f746g-disco board)
       run: |
         ./scripts/run_renode_tests.sh
+
+    - name: Upload Renode logs on failure
+      if: failure()
+      uses: actions/upload-artifact@v4
+      with:
+        name: renode-logs-stm32f746g-disco
+        path: |
+          build/connect.log
+          build/monitor.log
+        retention-days: 7
 
   build-all:
     name: All builds completed
     runs-on: ubuntu-latest
-    needs: [build-cmake, test-renode]
+    needs: [build-cmake, test-renode-stm32f746g-disco]
 
     permissions:
       contents: read

configs/renode/expected_logs.txt

@@ -1,5 +1,18 @@
 # Expected log messages from DMOD-Boot firmware running in Renode
-# Each line is a pattern that must appear in the monitor-gdb output
-# Lines starting with # are comments and empty lines are ignored
+# on the stm32f746g-disco board configuration.
+#
+# This test catches the hard-fault that occurred when .dmod.inputs was not
+# correctly copied to RAM during startup.  A corrupt .dmod.inputs caused
+# Dmod_ConnectApi to write garbage function pointers into loaded modules'
+# .dmod.outputs sections, leading to an immediate hard-fault whenever a
+# loaded driver (e.g. dmgpio via dmdevfs) tried to log a message.
+#
+# All lines below must appear in the monitor-gdb output.  If the firmware
+# crashes before completing initialization, none of the later lines will
+# appear and the test will fail.
+#
+# Each line is a literal substring to match in the log (grep -q).
+# Lines starting with # and empty lines are ignored.
 
-DMOD-Boot started
+Heap initialized
+DMOD-Boot started

scripts/run_renode_tests.sh

@@ -1,9 +1,12 @@
 #!/bin/bash
 # run_renode_tests.sh - Run Renode emulation tests for dmod-boot
 #
-# This script reproduces the Renode CI tests locally.
-# It builds the firmware with emulation mode, starts Renode, runs monitor-gdb
-# to capture firmware logs, and verifies the expected log messages.
+# This script builds the stm32f746g-disco firmware with Renode emulation mode,
+# starts Renode, runs monitor-gdb to capture firmware logs, and verifies that
+# the expected log messages appear.  In particular it catches the hard-fault
+# that occurs when .dmod.inputs is not correctly copied to RAM at startup
+# (which prevents Dmod_EnterCritical and other output function pointers from
+# being connected when modules are loaded at runtime).
 #
 # Usage:
 #   ./scripts/run_renode_tests.sh [SOURCE_DIR [BUILD_DIR]]
@@ -24,21 +27,33 @@ EXPECTED_LOGS="$SOURCE_DIR/configs/renode/expected_logs.txt"
 VERIFY_SCRIPT="$SOURCE_DIR/scripts/verify_renode_logs.sh"
 
 # Timeouts (seconds)
-CONNECT_TIMEOUT=90
-MONITOR_TIMEOUT=30
+CONNECT_TIMEOUT=120
+MONITOR_TIMEOUT=60
 
 echo "=============================================="
 echo " dmod-boot Renode emulation tests"
+echo " Board: $BOARD"
 echo "=============================================="
 echo "Source dir : $SOURCE_DIR"
 echo "Build dir  : $BUILD_DIR"
 echo "Board      : $BOARD"
 echo ""
 
+# Cleanup helper – kill any lingering background processes on exit
+cleanup() {
+    if [ -n "$CONNECT_PID" ] && ps -p "$CONNECT_PID" > /dev/null 2>&1; then
+        kill "$CONNECT_PID" 2>/dev/null || true
+    fi
+    if [ -n "$MONITOR_PID" ] && ps -p "$MONITOR_PID" > /dev/null 2>&1; then
+        kill "$MONITOR_PID" 2>/dev/null || true
+    fi
+}
+trap cleanup EXIT
+
 # -------------------------------------------------------
 # Step 1 – Build firmware with emulation mode enabled
 # -------------------------------------------------------
-echo "[1/4] Building firmware with emulation mode enabled..."
+echo "[1/4] Building firmware (BOARD=$BOARD, DMBOOT_EMULATION=ON)..."
 cmake -DCMAKE_BUILD_TYPE=Debug \
       -DBOARD="$BOARD" \
       -DDMBOOT_EMULATION=ON \
@@ -89,13 +104,19 @@ MONITOR_LOG="$BUILD_DIR/monitor.log"
 timeout "$MONITOR_TIMEOUT" cmake --build "$BUILD_DIR" --target monitor-gdb > "$MONITOR_LOG" 2>&1 &
 MONITOR_PID=$!
 
-# Give the firmware time to produce log output
+# Give the firmware time to boot and produce log output
+echo "Waiting ${MONITOR_TIMEOUT}s for firmware to boot..."
 sleep "$MONITOR_TIMEOUT"
 
 echo "Monitor output:"
 cat "$MONITOR_LOG"
 echo ""
 
+# Also show the Renode connect log for diagnostics
+echo "--- connect.log (last 40 lines) ---"
+tail -40 "$CONNECT_LOG" || true
+echo ""
+
 # Verify expected log messages
 bash "$VERIFY_SCRIPT" "$MONITOR_LOG" "$EXPECTED_LOGS"
 VERIFY_STATUS=$?