PSP keepalive: stop scaring users with the expected error response (win.21)

mctrivia's /keepalive endpoint always returns
  {"error":"unsubscribe failed will time out anyways"}
even on successful keepalives that result in payments. Confirmed by
direct curl from a working Linux node. The verbose diagnostic logging
we added during win.14-16 debugging is now shipping noise: every 20
minutes the user sees a CRITICAL-looking "RESPONSE: {error: ...}" line
that's actually fine.

- Recognise the known-OK response substring and treat it as success;
  log "Reported online to ipfs.digiassetx.com" at INFO
- Anything else from the server gets a "UNEXPECTED response" warning
  so a real outage actually surfaces
- Demote the URL, body string, and raw response logs to DEBUG level
  (only visible after pressing [L] in the dashboard) — they include
  the secret code so they should never have been at INFO

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: chopperbriano

CMakeLists.txt

@@ -40,7 +40,7 @@ SET(PATCH_VERSION 0)
 SET(SO_VERSION    0)
 
 # Windows port build number (increment for each Windows-specific release)
-SET(WIN_BUILD 20)
+SET(WIN_BUILD 21)
 
 # Add source directory
 include_directories(src)

src/PermanentStoragePool/pools/mctrivia.cpp

@@ -248,19 +248,14 @@ void mctrivia::_callServer(ServerCalls command, const string& extra) {
     string url = "https://ipfs.digiassetx.com/" + commandStr;
     if (!extra.empty()) url += "/" + extra;
 
-    // Log the full request details
+    // Diagnostic detail at DEBUG level only — visible after pressing [L] in the
+    // dashboard. Includes the secret, so we never want it at INFO.
     if (command == KEEP_ALIVE) {
-        log->addMessage("PSP keepalive REQUEST: url=" + url, Log::INFO);
-        log->addMessage("PSP keepalive REQUEST: address=" + address + " peerId=" + peerId +
-            " visible=" + (_visible ? "v" : "h") + " secret=" + _secretCode, Log::INFO);
-    }
-
-    // Build the exact body string for debug logging
-    std::string body = "address=" + address + "&peerId=" + peerId +
-                       "&visible=" + (_visible ? std::string("v") : std::string("h")) +
-                       "&secret=" + _secretCode;
-    if (command == KEEP_ALIVE) {
-        log->addMessage("PSP keepalive REQUEST body: " + body, Log::INFO);
+        log->addMessage("PSP keepalive REQUEST: url=" + url, Log::DEBUG);
+        log->addMessage("PSP keepalive REQUEST body: address=" + address +
+                        "&peerId=" + peerId +
+                        "&visible=" + (_visible ? std::string("v") : std::string("h")) +
+                        "&secret=" + _secretCode, Log::DEBUG);
     }
 
     std::string response;
@@ -277,8 +272,23 @@ void mctrivia::_callServer(ServerCalls command, const string& extra) {
     }
 
     if (command == KEEP_ALIVE) {
-        log->addMessage("PSP keepalive RESPONSE: " + response, Log::INFO);
-        log->addMessage("Reported online to ipfs.digiassetx.com with server id: " + peerId);
+        // The server's `keepalive` endpoint always returns
+        //   {"error":"unsubscribe failed will time out anyways"}
+        // for both successful and unsuccessful keepalives — confirmed by direct
+        // curl from a working Linux node that DOES receive payments. The text
+        // is misleading; treat it as the expected OK response and only flag
+        // anything else as an actual problem.
+        const std::string expectedOk = "unsubscribe failed will time out anyways";
+        bool responseOk = (response.find(expectedOk) != std::string::npos);
+
+        log->addMessage("PSP keepalive RESPONSE: " + response, Log::DEBUG);
+        if (responseOk) {
+            log->addMessage("Reported online to ipfs.digiassetx.com (server id: " +
+                            peerId + ")");
+        } else {
+            log->addMessage("PSP keepalive returned UNEXPECTED response: " + response,
+                            Log::WARNING);
+        }
     }
 
     //update the bad list