Fix #14074 FP constParameterReference reported for std::array object when non-const pointer to internal data is returned (cppcheck-opensource#7890)

Co-authored-by: chrchr-github <noreply@github.com>

Author: chrchr-github

lib/checkother.cpp

@@ -1728,6 +1728,9 @@ void CheckOther::checkConstVariable()
                     retTok = retTok->astOperand2();
                 if (Token::simpleMatch(retTok, "&"))
                     retTok = retTok->astOperand1();
+                ValueFlow::Value ltVal = ValueFlow::getLifetimeObjValue(retTok);
+                if (ltVal.isLifetimeValue() && ltVal.tokvalue->varId() == var->declarationId())
+                    return true;
                 return ValueFlow::hasLifetimeToken(getParentLifetime(retTok), var->nameToken(), *mSettings);
             }))
                 continue;

test/testother.cpp

@@ -3964,6 +3964,9 @@ class TestOther : public TestFixture {
 
         check("void push(V& v) { v.push_back({ .x = 1 }); }"); // #14010
         ASSERT_EQUALS("", errout_str());
+
+        check("size_t* f(std::array<uint8_t, 128>& a) { return reinterpret_cast<size_t*>(a.data()); }\n"); // #14074
+        ASSERT_EQUALS("", errout_str());
     }
 
     void constParameterCallback() {