Merge pull request #19 from christophersmith262/bugfix/fix-external-dependencies

Fix external dependencies

Author: danielamorse

README.md

@@ -30,7 +30,7 @@ const DrupalLibrariesPlugin = require('drupal-libraries-webpack-plugin');
 
 module.exports = {
   plugins: [
-  	new DrupalLibrariesPlugin()
+    new DrupalLibrariesPlugin()
   ],
 };
 ```
@@ -45,6 +45,14 @@ You can explicitly add a Drupal library dependency to module by using a special
 require('@drupal(core/jquery)')
 ```
 
+Drupal libraries must be added as [external dependencies](https://webpack.js.org/configuration/externals/) in your webpack configuration:
+
+```js
+externals: {
+  '@drupal(drupal/core)': 'Drupal'
+}
+```
+
 ### Configuration
 
 #### `path`
@@ -137,7 +145,7 @@ module.exports = {
   plugins: [
   	new DrupalLibrariesPlugin({
   	  // Only pick up require('jquery') or require('Drupal') statements.
-  	  libraryPattern: /^(jquery|Drupal)$/
+  	  requirePattern: /^(jquery|Drupal)$/
   	})
   ],
 };

lib/DrupalLibrariesPlugin.js

@@ -49,19 +49,6 @@ class DrupalLibrariesPlugin {
    *   The webpack compiler.
    */
   apply(compiler) {
-    // Prevents drupal library dependencies from being included.
-    compiler.hooks.normalModuleFactory.tap('DrupalLibrariesPlugin', cmf => {
-      cmf.hooks.factorize.tapAsync("DrupalLibrariesPlugin", (data, callback) => {
-        const result = this.opts.requirePattern.exec(data.request)
-        if (result) {
-          callback(null, new DrupalLibraryModule(result[1]))
-        }
-        else {
-          return callback()
-        }
-      })
-    })
-
     // Analyzes the final chunks to determine library dependencies.
     compiler.hooks.done.tapPromise('DrupalLibrariesPlugin', async stats => {
       this.metadata = await this._generateLibraryMetadata(stats.compilation)

test/library-dependency.test.js

@@ -6,6 +6,9 @@ test('Generates a library entry for @drupal(core/drupal)', async () => {
     entry: {
       'require-drupal': path.resolve(__dirname, './fixtures/require-drupal.es6.js'),
     },
+    externals: {
+      '@drupal(drupal/core)': 'Drupal'
+    }
   })).result
 
   expect(result).toEqual({