phpstan level 9

Author: dominikzogg

composer.json

@@ -73,7 +73,7 @@
         "test:infection": "vendor/bin/infection --threads=$(nproc) --min-msi=100 --verbose --coverage=build/phpunit",
         "test:integration": "vendor/bin/phpunit --testsuite=Integration --cache-directory=build/phpunit",
         "test:lint": "mkdir -p build && find src tests -name '*.php' -print0 | xargs -0 -n1 -P$(nproc) php -l | tee build/phplint.log",
-        "test:static-analysis": "mkdir -p build && bash -c 'vendor/bin/phpstan analyse src --no-progress --level=8 --error-format=junit | tee build/phpstan.junit.xml; if [ ${PIPESTATUS[0]} -ne \"0\" ]; then exit 1; fi'",
+        "test:static-analysis": "mkdir -p build && bash -c 'vendor/bin/phpstan analyse src --no-progress --level=9 --error-format=junit | tee build/phpstan.junit.xml; if [ ${PIPESTATUS[0]} -ne \"0\" ]; then exit 1; fi'",
         "test:unit": "vendor/bin/phpunit --testsuite=Unit --coverage-text --coverage-clover=build/phpunit/clover.xml --coverage-html=build/phpunit/coverage-html --coverage-xml=build/phpunit/coverage-xml --log-junit=build/phpunit/junit.xml --cache-directory=build/phpunit"
     }
 }

src/Decoder/JsonTypeDecoder.php

@@ -30,6 +30,8 @@ public function decode(string $data): array
             throw RuntimeException::createNotParsable($this->getContentType(), 'Not an object');
         }
 
+        /** @var array<string, null|array|bool|float|int|string> $decoded */
+
         return $decoded;
     }
 }

src/Decoder/YamlTypeDecoder.php

@@ -32,6 +32,8 @@ public function decode(string $data): array
             throw RuntimeException::createNotParsable($this->getContentType(), 'Not an object');
         }
 
+        /** @var array<string, null|array|bool|float|int|string> $decoded */
+
         return $decoded;
     }
 }

src/ServiceFactory/DecoderFactory.php

@@ -14,8 +14,9 @@ final class DecoderFactory extends AbstractFactory
 {
     public function __invoke(ContainerInterface $container): DecoderInterface
     {
-        return new Decoder(
-            $container->get(TypeDecoderInterface::class.'[]'.$this->name)
-        );
+        /** @var array<int, TypeDecoderInterface> $decoderTypes */
+        $decoderTypes = $container->get(TypeDecoderInterface::class.'[]'.$this->name);
+
+        return new Decoder($decoderTypes);
     }
 }

src/ServiceFactory/EncoderFactory.php

@@ -14,8 +14,9 @@ final class EncoderFactory extends AbstractFactory
 {
     public function __invoke(ContainerInterface $container): EncoderInterface
     {
-        return new Encoder(
-            $container->get(TypeEncoderInterface::class.'[]'.$this->name)
-        );
+        /** @var array<int, TypeEncoderInterface> $encoderTypes */
+        $encoderTypes = $container->get(TypeEncoderInterface::class.'[]'.$this->name);
+
+        return new Encoder($encoderTypes);
     }
 }