Skip to content

Commit 77cf2ab

Browse files
authored
* fix for mitmproxy#4852 * changelog
1 parent d6ba677 commit 77cf2ab

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
* Add `client_replay_concurrency` option, which allows more than one client replay request to be in-flight at a time. (@rbdixon)
1212
* New content view which handles gRPC/protobuf. Allows to apply custom definitions to visualize different field decodings.
1313
Includes example addon which applies custom definitions for selected gRPC traffic (@mame82)
14+
* Fix a crash caused when editing string option (#4852, @rbdixon)
1415

1516
## 28 September 2021: mitmproxy 7.0.4
1617

mitmproxy/tools/console/options.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,8 @@ def keypress(self, size, key):
181181
foc, idx = self.get_focus()
182182
v = self.walker.get_edit_text()
183183
try:
184-
d = self.master.options.parse_setval(foc.opt, v)
184+
current = getattr(self.master.options, foc.opt.name)
185+
d = self.master.options.parse_setval(foc.opt, v, current)
185186
self.master.options.update(**{foc.opt.name: d})
186187
except exceptions.OptionsError as v:
187188
signals.status_message.send(message=str(v))

0 commit comments

Comments
 (0)