more

Author: onurctirtir

test_package_installation/common/run_multi_schedule.sh

@@ -10,7 +10,7 @@
 
 set -euo pipefail
 
-if [ -z "$1" ]; then
+if [ "$#" -ne 1 ]; then
     echo "Error: some arguments are missing." >&2
     echo "Usage: $0 <pg_binary_path>" >&2
     exit 1

test_package_installation/common/test_basics.sh

@@ -10,7 +10,7 @@
 
 set -euo pipefail
 
-if [ -z "$1" ] || [ -z "$2" ] || [ -z "$3" ]; then
+if [ "$#" -ne 3 ]; then
     echo "Error: some arguments are missing." >&2
     echo "Usage: $0 <expected_pg_major_version> <expected_citus_full_version> <pg_binary_path>" >&2
     exit 1
@@ -27,7 +27,7 @@ SHARDS_PER_NODE=5
 FIRST_NODE_PORT=9700
 
 run_psql_cmd() {
-    if [ -z "$1" ] || [ -z "$2" ]; then
+    if [ "$#" -ne 2 ]; then
         echo "Error: some arguments are missing." >&2
         echo "Usage: run_psql_cmd <port_number> <sql_command>" >&2
         exit 1
@@ -123,7 +123,7 @@ result=$(
 if [ "$result" = "t" ]; then
     echo "Verified cluster creation, distributed table creation and shard rebalancing. Shards are distributed evenly across nodes."
 else
-    echo "Error: Citus cluster creation failed. Shards are not distributed evenly across nodes, see below for details:" >&2
+    echo "Error: Failed. Shards are not distributed evenly across nodes, see below for details:" >&2
     run_psql_cmd "$FIRST_NODE_PORT" "
         SELECT nodeport,
                COUNT(shardid) AS cnt

test_package_installation/deb/install_package.sh

@@ -9,7 +9,7 @@
 
 set -euo pipefail
 
-if [ -z "$1" ] || [ -z "$2" ]; then
+if [ "$#" -ne 2 ]; then
     echo "Error: some arguments are missing." >&2
     echo "Usage: $0 <pg_major_version> <citus_full_version>" >&2
     exit 1

test_package_installation/deb/install_regression_test_deps.sh

@@ -9,7 +9,7 @@
 
 set -euo pipefail
 
-if [ -z "$1" ] || [ -z "$2" ]; then
+if [ "$#" -ne 2 ]; then
     echo "Error: some arguments are missing." >&2
     echo "Usage: $0 <pg_major_version> <citus_full_version>" >&2
     exit 1

test_package_installation/rpm/install_package.sh

@@ -9,7 +9,7 @@
 
 set -euo pipefail
 
-if [ -z "$1" ] || [ -z "$2" ] || [ -z "$3" ]; then
+if [ "$#" -ne 3 ]; then
     echo "Error: some arguments are missing." >&2
     echo "Usage: $0 <pg_major_version> <citus_full_version> <os_version>" >&2
     exit 1

test_package_installation/rpm/install_regression_test_deps.sh

@@ -9,7 +9,7 @@
 
 set -euo pipefail
 
-if [ -z "$1" ] || [ -z "$2" ]; then
+if [ "$#" -ne 2 ]; then
     echo "Error: some arguments are missing." >&2
     echo "Usage: $0 <pg_major_version> <citus_full_version>" >&2
     exit 1