Avoid calling get_ancestors() in template render

We now call it and pass through the result before rendering.

Author: meshy

cbv/templates/cbv/klass_detail.html

@@ -66,7 +66,6 @@ <h1><small>class</small>&nbsp;{{ klass.name }}</h1>
 {% block content %}
     <div class="span12">
         <div class="row">
-            {% with klass.get_ancestors as direct_ancestors %}
                 {% for ancestor in all_ancestors %}
                     {% if forloop.first %}
                         <div class="span4">
@@ -91,7 +90,6 @@ <h2>Descendants</h2>
                         <li><a href="{{ child.get_absolute_url }}">{{ child.name }}</a></li>
                     {% if forloop.last %}</ul></div>{% endif %}
                 {% endfor %}
-            {% endwith %}
         </div>
 
         <div class="row">

cbv/views.py

@@ -45,11 +45,13 @@ def get_context_data(self, **kwargs):
         nav = nav_builder.get_nav_data(
             klass.module.project_version, klass.module, klass
         )
+        direct_ancestors = list(klass.get_ancestors())
         return {
             "all_ancestors": list(klass.get_all_ancestors()),
             "all_children": list(klass.get_all_children()),
             "attributes": klass.get_prepared_attributes(),
             "canonical_url": self.request.build_absolute_uri(canonical_url_path),
+            "direct_ancestors": direct_ancestors,
             "klass": klass,
             "methods": list(klass.get_methods()),
             "nav": nav,

tests/_page_snapshots/fuzzy-klass-detail-old.html

@@ -407,7 +407,6 @@ <h1><small>class</small>&nbsp;FormView</h1>
             <div class="row">
     <div class="span12">
         <div class="row">
-            
 
 
                         <div class="span4">
@@ -484,7 +483,6 @@ <h2>Descendants</h2>
                         <li><a href="/projects/Django/3.2/django.contrib.auth.views/PasswordResetView/">PasswordResetView</a></li>
                     </ul></div>
 
-            
         </div>
 
         <div class="row">

tests/_page_snapshots/fuzzy-klass-detail.html

@@ -407,7 +407,6 @@ <h1><small>class</small>&nbsp;FormView</h1>
             <div class="row">
     <div class="span12">
         <div class="row">
-            
 
 
                         <div class="span4">
@@ -484,7 +483,6 @@ <h2>Descendants</h2>
                         <li><a href="/projects/Django/4.0/django.contrib.auth.views/PasswordResetView/">PasswordResetView</a></li>
                     </ul></div>
 
-            
         </div>
 
         <div class="row">

tests/_page_snapshots/klass-detail-old.html

@@ -403,7 +403,6 @@ <h1><small>class</small>&nbsp;FormView</h1>
             <div class="row">
     <div class="span12">
         <div class="row">
-            
 
 
                         <div class="span4">
@@ -480,7 +479,6 @@ <h2>Descendants</h2>
                         <li><a href="/projects/Django/3.2/django.contrib.auth.views/PasswordResetView/">PasswordResetView</a></li>
                     </ul></div>
 
-            
         </div>
 
         <div class="row">

tests/_page_snapshots/klass-detail.html

@@ -403,7 +403,6 @@ <h1><small>class</small>&nbsp;FormView</h1>
             <div class="row">
     <div class="span12">
         <div class="row">
-            
 
 
                         <div class="span4">
@@ -480,7 +479,6 @@ <h2>Descendants</h2>
                         <li><a href="/projects/Django/4.0/django.contrib.auth.views/PasswordResetView/">PasswordResetView</a></li>
                     </ul></div>
 
-            
         </div>
 
         <div class="row">