Add failing test

Author: znichollscr

tests/integration/cli/test_validate_tree.py

@@ -23,7 +23,10 @@
     prepare_ds_and_get_frequency,
 )
 from input4mips_validation.inference.from_data import BoundsInfo
-from input4mips_validation.testing import get_valid_ds_min_metadata_example
+from input4mips_validation.testing import (
+    get_valid_ds_min_metadata_example,
+    get_valid_ds_min_metadata_example_climatology,
+)
 from input4mips_validation.validation.tree import get_validate_tree_result
 
 UR = pint.get_application_registry()
@@ -96,3 +99,65 @@ def test_basic(tmp_path):
         result = runner.invoke(app, ["validate-tree", str(tmp_path)])
 
     assert result.exit_code == 0, result.exc_info
+
+
+def test_climatology(tmp_path):
+    """
+    Write a climatology file in a tree, then make sure we can validate the tree
+    """
+    cvs = load_cvs(cv_source=DEFAULT_TEST_INPUT4MIPS_CV_SOURCE)
+
+    # Create ourselves a tree
+    written_files = []
+    for variable_id, units in (
+        ("mole_fraction_of_carbon_dioxide_in_air", "ppm"),
+        # ("mole_fraction_of_methane_in_air", "ppb"),
+    ):
+        ds, metadata_minimum = get_valid_ds_min_metadata_example_climatology(
+            variable_id=variable_id, units=units
+        )
+
+        ds["time"].encoding = {
+            "calendar": "proleptic_gregorian",
+            "units": "days since 1850-01-01 00:00:00",
+            # Time has to be encoded as float
+            # to ensure that half-days etc. are handled.
+            "dtype": np.dtypes.Float32DType,
+        }
+
+        input4mips_ds = Input4MIPsDataset.from_data_producer_minimum_information(
+            data=ds,
+            metadata_minimum=metadata_minimum,
+            cvs=cvs,
+            dataset_category="GHGConcentrations",
+            realm="atmos",
+            prepare_func=partial(
+                prepare_ds_and_get_frequency,
+                standard_and_or_long_names={
+                    variable_id: {"standard_name": variable_id}
+                },
+            ),
+        )
+
+        written_file = input4mips_ds.write(root_data_dir=tmp_path)
+
+        written_files.append(written_file)
+
+    # Test the function directly first (helps with debugging)
+    get_validate_tree_result(
+        tmp_path,
+        cv_source=DEFAULT_TEST_INPUT4MIPS_CV_SOURCE,
+        bounds_info=BoundsInfo(
+            time_bounds="time_bnds",
+            bounds_dim="bnds",
+        ),
+    ).raise_if_errors()
+
+    # Then test the CLI
+    with patch.dict(
+        os.environ,
+        {"INPUT4MIPS_VALIDATION_CV_SOURCE": str(DEFAULT_TEST_INPUT4MIPS_CV_SOURCE)},
+    ):
+        result = runner.invoke(app, ["validate-tree", str(tmp_path)])
+
+    assert result.exit_code == 0, result.exc_info