LITE-28260 Fix errors

Author: bdjilka

connect/cli/plugins/commerce/utils.py

@@ -280,7 +280,7 @@ def export_stream(
             data={
                 'Stream ID': stream_id,
                 'Stream Name': response['name'],
-                'Stream Description': response['description'],
+                'Stream Description': response.get('description'),
                 'Stream Type': stream_type,
                 'Stream Category': 'Inbound'
                 if response['owner']['id'] != active_account_id
@@ -883,9 +883,17 @@ def update_general_information(
             'context',
             'samples',
             'sources',
+            'validation',
         )
         .first()
     )
+
+    if stream['status'] == 'active' or stream.get('validation', {}).get('status') == 'processing':
+        raise ClickException(
+            f'Stream {stream_id} cannot be updated because it is in "active" status '
+            f'or validation is processing.',
+        )
+
     body = {'context': {}}
     updated = 0
     errors_on_update = 0
@@ -894,7 +902,7 @@ def update_general_information(
         if h.value == 'Stream Name' and stream['name'] != v.value:
             body['name'] = v.value
             updated += 1
-        elif h.value == 'Stream Description' and stream['description'] != v.value:
+        elif h.value == 'Stream Description' and stream.get('description') != v.value:
             body['description'] = v.value
             updated += 1
         elif (
@@ -963,9 +971,7 @@ def update_transformations(
             to_update = {}
             if origin_trf['settings'] != json.loads(settings.value):
                 to_update['settings'] = json.loads(settings.value)
-            if descr.value and (
-                'description' not in origin_trf or origin_trf['description'] != descr.value
-            ):
+            if origin_trf.get('description') != descr.value:
                 to_update['description'] = descr.value
             if int(origin_trf['position']) != position.value:
                 to_update['position'] = int(position.value)

tests/plugins/commerce/test_commands.py

@@ -847,9 +847,10 @@ def test_sync_stream(
 
     with open('./tests/fixtures/commerce/stream_retrieve_response.json') as content:
         response = json.load(content)[0]
+        response['status'] = 'configuring'
         mocked_responses.add(
             method='GET',
-            url='https://localhost/public/v1/billing/streams?eq(id,STR-7748-7021-7449)&select(context,samples,sources)&limit=1&offset=0',
+            url='https://localhost/public/v1/billing/streams?eq(id,STR-7748-7021-7449)&select(context,samples,sources,validation)&limit=1&offset=0',
             json=[response],
         )
     mocked_responses.add(
@@ -969,3 +970,50 @@ def test_sync_stream_no_stream(
 
     assert result.exit_code == 1
     assert 'Stream STR-7748-7021-7449 not found for the current account VA-000.' in result.output
+
+
+def test_sync_stream_active_stream(
+    mocker,
+    ccli,
+    mocked_responses,
+    config_mocker,
+    load_stream_sync,
+):
+    mocker.patch(
+        'connect.cli.plugins.commerce.utils.get_work_book',
+        return_value=load_stream_sync,
+    )
+    mocker.patch(
+        'connect.cli.plugins.commerce.utils.upload_attachment',
+        return_value={'id': 'ID'},
+    )
+    mocked_responses.add(
+        method='GET',
+        url='https://localhost/public/v1/billing/streams?eq(id,STR-7748-7021-7449)&limit=0&offset=0',
+        headers={
+            'Content-Range': 'items 0-1/1',
+        },
+    )
+
+    with open('./tests/fixtures/commerce/stream_retrieve_response.json') as content:
+        response = json.load(content)[0]
+        mocked_responses.add(
+            method='GET',
+            url='https://localhost/public/v1/billing/streams?eq(id,STR-7748-7021-7449)&select(context,samples,sources,validation)&limit=1&offset=0',
+            json=[response],
+        )
+
+    runner = CliRunner()
+    cmd = [
+        'commerce',
+        'stream',
+        'sync',
+        'STR-7748-7021-7449',
+    ]
+    result = runner.invoke(
+        ccli,
+        cmd,
+    )
+
+    assert result.exit_code == 1
+    assert 'Stream STR-7748-7021-7449 cannot be updated because it is in "active"' in result.output

tests/plugins/commerce/test_utils.py

@@ -337,7 +337,7 @@ def test_update_general_information_error(sample_stream_workbook, mocker, mocked
         method='GET',
         url='https://localhost/public/v1/billing/streams?'
         'eq(id,STR-7755-7115-2464)&select(context,samples,sources)&limit=1&offset=0',
-        json=[{'name': 'Name', 'description': 'Description'}],
+        json=[{'name': 'Name', 'description': 'Description', 'status': 'configuring'}],
     )
 
     mocked_responses.add(