Skip to content

Commit 8c26168

Browse files
committed
Fix: do not send Authorization header when uploading
1 parent 726a325 commit 8c26168

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

src/main/java/com/cloudconvert/resource/async/AsyncImportFilesResource.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import com.cloudconvert.dto.result.Result;
1616
import com.cloudconvert.executor.AsyncRequestExecutor;
1717
import com.cloudconvert.resource.AbstractImportFilesResource;
18+
import com.cloudconvert.resource.AbstractResource;
1819
import com.google.common.collect.ImmutableList;
1920
import lombok.extern.slf4j.Slf4j;
2021
import org.apache.http.HttpEntity;
@@ -31,6 +32,8 @@
3132
import java.net.URISyntaxException;
3233
import java.util.concurrent.ExecutionException;
3334

35+
import static com.cloudconvert.resource.AbstractResource.*;
36+
3437
@Slf4j
3538
public class AsyncImportFilesResource extends AbstractImportFilesResource<AsyncResult<TaskResponse>> {
3639

@@ -101,7 +104,7 @@ public AsyncResult<TaskResponse> upload(
101104
final URI multipartUri = new URI(taskResponseResultForm.getUrl());
102105
final HttpEntity multipartHttpEntity = getMultipartHttpEntity(taskResponseResultForm, file);
103106
final HttpUriRequest multipartHttpUriRequest = getHttpUriRequest(HttpPost.class, multipartUri, multipartHttpEntity);
104-
107+
multipartHttpUriRequest.removeHeaders(HEADER_AUTHORIZATION);
105108
return uploadPostProcess(taskId, asyncRequestExecutor.execute(multipartHttpUriRequest, VOID_TYPE_REFERENCE));
106109
} catch (InterruptedException | ExecutionException e) {
107110
throw new IOException(e);
@@ -143,7 +146,7 @@ public AsyncResult<TaskResponse> upload(
143146
final URI multipartUri = new URI(taskResponseResultForm.getUrl());
144147
final HttpEntity multipartHttpEntity = getMultipartHttpEntity(taskResponseResultForm, inputStream);
145148
final HttpUriRequest multipartHttpUriRequest = getHttpUriRequest(HttpPost.class, multipartUri, multipartHttpEntity);
146-
149+
multipartHttpUriRequest.removeHeaders(HEADER_AUTHORIZATION);
147150
return uploadPostProcess(taskId, asyncRequestExecutor.execute(multipartHttpUriRequest, VOID_TYPE_REFERENCE));
148151
} catch (InterruptedException | ExecutionException e) {
149152
throw new IOException(e);

src/main/java/com/cloudconvert/resource/sync/ImportFilesResource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public Result<TaskResponse> upload(
9191
final URI multipartUri = new URI(taskResponseResultForm.getUrl());
9292
final HttpEntity multipartHttpEntity = getMultipartHttpEntity(taskResponseResultForm, file);
9393
final HttpUriRequest multipartHttpUriRequest = getHttpUriRequest(HttpPost.class, multipartUri, multipartHttpEntity);
94-
94+
multipartHttpUriRequest.removeHeaders(HEADER_AUTHORIZATION);
9595
return uploadPostProcess(taskId, requestExecutor.execute(multipartHttpUriRequest, VOID_TYPE_REFERENCE));
9696
}
9797

@@ -122,7 +122,7 @@ public Result<TaskResponse> upload(
122122
final URI multipartUri = new URI(taskResponseResultForm.getUrl());
123123
final HttpEntity multipartHttpEntity = getMultipartHttpEntity(taskResponseResultForm, inputStream);
124124
final HttpUriRequest multipartHttpUriRequest = getHttpUriRequest(HttpPost.class, multipartUri, multipartHttpEntity);
125-
125+
multipartHttpUriRequest.removeHeaders(HEADER_AUTHORIZATION);
126126
return uploadPostProcess(taskId, requestExecutor.execute(multipartHttpUriRequest, VOID_TYPE_REFERENCE));
127127
}
128128

0 commit comments

Comments
 (0)