Iron out a few more type issues

Author: KnorpelSenf

lib/JobsResource.ts

@@ -12,7 +12,11 @@ export interface Job {
     created_at: string;
     started_at: string | null;
     ended_at: string | null;
-    tasks: Task[];
+    tasks: JobTask[];
+}
+type NotPresentWhenInsideJob = 'job_id'
+interface JobTask extends Omit<Task, NotPresentWhenInsideJob> {
+    name: string;
 }
 
 export default class JobsResource {
@@ -42,7 +46,7 @@ export default class JobsResource {
     }
 
     // See below for an explanation on how this type signature works
-    async create(data: { tasks: TaskContainer } | null = null): Promise<Job> {
+    async create(data: JobTemplate | null = null): Promise<Job> {
         const response = await this.cloudConvert.axios.post('jobs', data);
         return response.data.data;
     }
@@ -75,12 +79,15 @@ interface NamedOperation<O> { operation: O }
 type OperationByName<O> = Extract<Operation, NamedOperation<O>>
 // Given an operation string O, get the operation data for it
 type OperationData<O> = OperationByName<O>['data'];
+// Add all properties to task that can only occur in tasks that are inside jobs
+interface TaskExtras<O> extends NamedOperation<O> { ignore_error?: boolean; }
 // Every argument in the tasks object is typed by this (for some operation string O)
-type TaskTemplate<O> = NamedOperation<O> & OperationData<O>;
+type TaskTemplate<O> = TaskExtras<O> & OperationData<O>;
 // Given a union type U of operation strings, turn each operation string into its TaskTemplate
 type Distribute<U> = U extends any ? TaskTemplate<U> : never;
 // Create a union of all possible tasks
 type PossibleOperations = Distribute<PossibleOperationStrings>;
 // Allow any number of names, each typed by a possible operation
 interface TaskContainer { [name: string]: PossibleOperations; }
-// Yay! We can now use this container for our function signature above.
+// Add the other properties that are required for job creation
+interface JobTemplate { tasks: TaskContainer; tag?: string; }

lib/TasksResource.ts

@@ -317,7 +317,11 @@ export interface Task {
     engine: string;
     engine_version: string;
     payload: any;
-    result: any;
+    result?: { files?: FileResult[]; [key: string]: any; };
+}
+export interface FileResult {
+    filename: string;
+    url?: string;
 }
 
 export default class TasksResource {