chore: migrate ESLint config

Author: KnorpelSenf

.eslintignore

@@ -0,0 +1,54 @@
+import { defineConfig, globalIgnores } from 'eslint/config';
+import typescriptEslint from '@typescript-eslint/eslint-plugin';
+import globals from 'globals';
+import tsParser from '@typescript-eslint/parser';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import js from '@eslint/js';
+import { FlatCompat } from '@eslint/eslintrc';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default defineConfig([
+    globalIgnores([
+        '**/node_modules/',
+        '**/built/',
+        '**/package-lock.json',
+        '**/package.json',
+        'tests/unit/requests/',
+        'tests/unit/responses/',
+        '.vscode/',
+        'tsconfig.json'
+    ]),
+    {
+        extends: compat.extends(
+            'eslint:recommended',
+            'plugin:@typescript-eslint/recommended'
+        ),
+
+        plugins: {
+            '@typescript-eslint': typescriptEslint
+        },
+
+        languageOptions: {
+            globals: {
+                ...globals.browser,
+                ...globals.node
+            },
+
+            parser: tsParser,
+            ecmaVersion: 'latest',
+            sourceType: 'module'
+        },
+
+        rules: {
+            '@typescript-eslint/no-explicit-any': 'off'
+        }
+    }
+]);

.eslintrc.json

@@ -76,7 +76,6 @@ export class UploadFile {
         }
 
         if (Symbol.asyncIterator in data) {
-            const it = data[Symbol.asyncIterator]();
             for await (const chunk of data) {
                 if (typeof chunk === 'string')
                     throw new Error(

eslint.config.mjs

@@ -22,6 +22,8 @@
         "socket.io-client": "^4.7.4"
     },
     "devDependencies": {
+        "@eslint/eslintrc": "^3.3.1",
+        "@eslint/js": "^9.24.0",
         "@types/chai": "^5.2.1",
         "@types/mocha": "^10.0.10",
         "@types/node": "^20.11.19",
@@ -33,6 +35,7 @@
         "eslint-config-prettier": "^10.1.2",
         "eslint-config-typescript": "^3.0.0",
         "eslint-plugin-prettier": "^5.1.3",
+        "globals": "^16.0.0",
         "mocha": "^11.1.0",
         "nock": "^14.0.3",
         "prettier": "3.5.3",

lib/CloudConvert.ts

@@ -6,17 +6,20 @@ import apiKey from './ApiKey.js';
 import axios from 'axios';
 
 describe('JobsResource', () => {
+    let cloudConvert: CloudConvert;
+    let tmpPath: string;
+
     beforeEach(() => {
-        this.cloudConvert = new CloudConvert(apiKey, true);
+        cloudConvert = new CloudConvert(apiKey, true);
     });
 
     describe('create()', () => {
         beforeEach(() => {
-            this.tmpPath = os.tmpdir() + '/tmp.png';
+            tmpPath = os.tmpdir() + '/tmp.png';
         });
 
         it('test upload and download files', async () => {
-            let job = await this.cloudConvert.jobs.create({
+            let job = await cloudConvert.jobs.create({
                 tag: 'integration-test-upload-download',
                 tasks: {
                     'import-it': { operation: 'import/upload' },
@@ -32,18 +35,18 @@ describe('JobsResource', () => {
                 __dirname + '/../integration/files/input.png'
             );
 
-            await this.cloudConvert.tasks.upload(uploadTask, stream);
+            await cloudConvert.tasks.upload(uploadTask, stream);
 
-            job = await this.cloudConvert.jobs.wait(job.id);
+            job = await cloudConvert.jobs.wait(job.id);
 
             assert.equal(job.status, 'finished');
 
             // download export file
-            const file = this.cloudConvert.jobs.getExportUrls(job)[0];
+            const file = cloudConvert.jobs.getExportUrls(job)[0];
 
             assert.equal(file.filename, 'input.png');
 
-            const writer = fs.createWriteStream(this.tmpPath);
+            const writer = fs.createWriteStream(tmpPath);
 
             const response = await axios(file.url, { responseType: 'stream' });
 
@@ -55,21 +58,21 @@ describe('JobsResource', () => {
             });
 
             // check file size
-            const stat = fs.statSync(this.tmpPath);
+            const stat = fs.statSync(tmpPath);
 
             assert.equal(stat.size, 46937);
 
-            await this.cloudConvert.jobs.delete(job.id);
+            await cloudConvert.jobs.delete(job.id);
         }).timeout(30000);
 
         afterEach(() => {
-            fs.unlinkSync(this.tmpPath);
+            fs.unlinkSync(tmpPath);
         });
     });
 
     describe('subscribeEvent()', () => {
         it('test listening for finished event', async () => {
-            let job = await this.cloudConvert.jobs.create({
+            const job = await cloudConvert.jobs.create({
                 tag: 'integration-test-socket',
                 tasks: {
                     'import-it': { operation: 'import/upload' },
@@ -85,23 +88,19 @@ describe('JobsResource', () => {
                 __dirname + '/../integration/files/input.png'
             );
 
-            this.cloudConvert.tasks.upload(uploadTask, stream);
+            cloudConvert.tasks.upload(uploadTask, stream);
 
             const event = await new Promise(resolve => {
-                this.cloudConvert.jobs.subscribeEvent(
-                    job.id,
-                    'finished',
-                    resolve
-                );
+                cloudConvert.jobs.subscribeEvent(job.id, 'finished', resolve);
             });
 
             assert.equal(event.job.status, 'finished');
 
-            await this.cloudConvert.jobs.delete(job.id);
+            await cloudConvert.jobs.delete(job.id);
         }).timeout(30000);
 
         afterEach(() => {
-            this.cloudConvert.closeSocket();
+            cloudConvert.closeSocket();
         });
     });
 });

package.json

@@ -4,28 +4,30 @@ import * as fs from 'fs';
 import apiKey from './ApiKey.js';
 
 describe('TasksResource', () => {
+    let cloudConvert: CloudConvert;
+
     beforeEach(() => {
-        this.cloudConvert = new CloudConvert(apiKey, true);
+        cloudConvert = new CloudConvert(apiKey, true);
     });
 
     describe('upload()', () => {
         it('uploads input.png', async () => {
-            let task = await this.cloudConvert.tasks.create('import/upload', {
+            let task = await cloudConvert.tasks.create('import/upload', {
                 name: 'upload-test'
             });
 
             const stream = fs.createReadStream(
                 __dirname + '/../integration/files/input.png'
             );
 
-            await this.cloudConvert.tasks.upload(task, stream);
+            await cloudConvert.tasks.upload(task, stream);
 
-            task = await this.cloudConvert.tasks.wait(task.id);
+            task = await cloudConvert.tasks.wait(task.id);
 
             assert.equal(task.status, 'finished');
             assert.equal(task.result.files[0].filename, 'input.png');
 
-            await this.cloudConvert.tasks.delete(task.id);
+            await cloudConvert.tasks.delete(task.id);
         }).timeout(30000);
     });
 });

tests/integration/JobsResourceTest.ts

@@ -3,13 +3,15 @@ import apiKey from './ApiKey.js';
 import { assert } from 'chai';
 
 describe('UsersResource', () => {
+    let cloudConvert: CloudConvert;
+
     beforeEach(() => {
-        this.cloudConvert = new CloudConvert(apiKey, true);
+        cloudConvert = new CloudConvert(apiKey, true);
     });
 
     describe('me()', () => {
         it('should fetch the current user', async () => {
-            const data = await this.cloudConvert.users.me();
+            const data = await cloudConvert.users.me();
 
             console.log(data);
 

tests/integration/TasksResourceTest.ts

@@ -17,11 +17,7 @@
         "strict": true,
         "resolveJsonModule": true,
         "target": "es6",
-        "typeRoots": [
-            "./node_modules/@types"
-        ]
+        "typeRoots": ["./node_modules/@types"]
     },
-    "include": [
-        "./lib/*",
-    ]
-}
+    "include": ["./lib/*"]
+}