Skip to content

Commit ebb7bb6

Browse files
authored
Merge pull request #55 from KnorpelSenf/fix-upload-type
Fix type of task upload, allow using tasks from within jobs
2 parents 68012b1 + 61a9432 commit ebb7bb6

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

lib/JobsResource.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export interface Job {
1616
tasks: JobTask[];
1717
}
1818
type NotPresentWhenInsideJob = 'job_id' | 'status'
19-
interface JobTask extends Omit<Task, NotPresentWhenInsideJob> {
19+
export interface JobTask extends Omit<Task, NotPresentWhenInsideJob> {
2020
name: string;
2121
status: JobTaskStatus;
2222
}

lib/TasksResource.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import FormData, { Stream } from 'form-data';
22
import CloudConvert from './CloudConvert';
3+
import { JobTask } from './JobsResource';
34

45
export type TaskEvent = 'created' | 'updated' | 'finished' | 'failed';
56
export type TaskStatus = 'waiting' | 'processing' | 'finished' | 'error';
@@ -359,7 +360,7 @@ export default class TasksResource {
359360
await this.cloudConvert.axios.delete('tasks/' + id);
360361
}
361362

362-
async upload(task: Task, stream: Stream): Promise<any> {
363+
async upload(task: Task | JobTask, stream: Stream): Promise<any> {
363364

364365
if (task.operation !== 'import/upload') {
365366
throw new Error('The task operation is not import/upload');

0 commit comments

Comments
 (0)