Simplify client init

Author: stevelacey

lib/cloudconvert/client.rb

@@ -7,19 +7,18 @@ class Client
     # @param options [Hash]
     # @return [CloudConvert::Client]
     def initialize(options = {})
-      @api_key = ENV["CLOUDCONVERT_API_KEY"]
-      @sandbox = ENV["CLOUDCONVERT_SANDBOX"].to_s.downcase === "true"
-
-      options.each do |key, value|
-        instance_variable_set("@#{key}", value)
-      end
-
       schema = Schemacop::Schema.new do
         req! :api_key, :string
         opt! :sandbox, :boolean, default: false
       end
 
-      schema.validate!({ api_key: api_key, sandbox: sandbox }.compact)
+      schema.validate! options.reverse_merge!({
+        api_key: ENV["CLOUDCONVERT_API_KEY"],
+        sandbox: ENV["CLOUDCONVERT_SANDBOX"].to_s.downcase == "true",
+      })
+
+      @api_key = options[:api_key]
+      @sandbox = options[:sandbox]
     end
 
     # @return [Resources::Jobs]
@@ -43,9 +42,7 @@ def users
     # @return [OpenStruct]
     def request(method, path, params = {}, &block)
       response = connection.send(method, path, params, &block)
-
       raise CloudConvert::Error.from_response(response) unless response.success?
-
       response.body unless response.body.blank?
     end
 

lib/cloudconvert/resources/jobs.rb

@@ -32,7 +32,7 @@ def create(params)
         payload = params.dup
 
         payload[:tasks] = payload[:tasks].to_h do |task|
-          [task[:name], task.reject { |k| k === :name }]
+          [task[:name], task.reject { |k| k == :name }]
         end
 
         Job.result(client.post("/v2/jobs", payload))

lib/cloudconvert/sdk.rb

@@ -1,4 +1,5 @@
 require "active_support/concern"
+require "active_support/core_ext/hash/reverse_merge"
 require "down"
 require "equalizer"
 require "faraday"