File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -858,7 +858,7 @@ def test_slo_manifest_error_rate_bug(self):
858858 """
859859 BUG-2: When slo_type='error_rate', generate_slo_manifest() should
860860 return at least one SLO entry capturing the error rate objective,
861- but currently returns an empty slos list .
861+ and that entry should have name == 'error_rate' .
862862 """
863863 args = _sre_args (slo_type = "error_rate" )
864864 manifest = scaffold_sre .generate_slo_manifest (args )
@@ -867,6 +867,8 @@ def test_slo_manifest_error_rate_bug(self):
867867 "Expected at least one SLO entry for error_rate type, "
868868 "got empty list."
869869 )
870+ slo_names = [s ["name" ] for s in manifest ["slos" ]]
871+ assert "error_rate" in slo_names
870872
871873 def test_slo_manifest_all_type_has_both_slos (self ):
872874 args = _sre_args (slo_type = "all" )
You can’t perform that action at this time.
0 commit comments