Merge pull request #24 from sivasubramanian95/fix/gitlab-empty-stages

fix(gitlab-ci): prevent empty stages when kubernetes disabled

Author: chefgs

cli/scaffold_gitlab.py

@@ -93,7 +93,7 @@ def _global_section(args):
         stages.append("build")
     if args.type in ("test", "complete"):
         stages.append("test")
-    if args.type in ("deploy", "complete") and args.kubernetes:
+    if args.type == "deploy" or (args.type == "complete" and args.kubernetes):
         stages.append("deploy")
 
     return {

tests/test_comprehensive.py

@@ -614,17 +614,7 @@ def test_build_job_docker_services(self):
             # Build job uses docker-in-docker services
             assert "services" in data["build"]
 
-    # BUG-1: deploy pipeline with no kubernetes produces empty stages list
-    @pytest.mark.xfail(
-        strict=True,
-        reason=(
-            "BUG-1: When type='deploy' and kubernetes=False, _global_section() "
-            "produces an empty stages list because the 'deploy' stage is only "
-            "appended when args.kubernetes is True. A deploy-only pipeline "
-            "without Kubernetes has no valid stages, making it an invalid "
-            "GitLab CI pipeline."
-        ),
-    )
+    # BUG-1 regression: deploy pipeline with no kubernetes must still have stages
     def test_deploy_pipeline_no_kubernetes_empty_stages(self):
         """
         BUG-1: When type='deploy' and kubernetes=False, the generated