Skip to content
This repository was archived by the owner on Apr 2, 2019. It is now read-only.

Commit 04ae8aa

Browse files
committed
Fix #544, add column name to class name list in td
1 parent f939157 commit 04ae8aa

2 files changed

Lines changed: 15 additions & 13 deletions

File tree

src/cell.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,9 @@ var Cell = Backgrid.Cell = Backbone.View.extend({
268268
var $el = this.$el;
269269
$el.empty();
270270
var model = this.model;
271-
$el.text(this.formatter.fromRaw(model.get(this.column.get("name")), model));
271+
var columnName = this.column.get("name");
272+
$el.text(this.formatter.fromRaw(model.get(columnName), model));
273+
$el.addClass(columnName);
272274
this.updateStateClassesMaybe();
273275
this.delegateEvents();
274276
return this;

test/body.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ describe("A Body", function () {
2929
var $trs = body.$el.children();
3030
expect($trs.length).toBe(3);
3131
expect($(body.el).html().toLowerCase().replace(/\s*</g, '<'))
32-
.toBe('<tr><td class="integer-cell editable sortable renderable">2</td></tr>' +
33-
'<tr><td class="integer-cell editable sortable renderable">1</td></tr>' +
34-
'<tr><td class="integer-cell editable sortable renderable">3</td></tr>');
32+
.toBe('<tr><td class="integer-cell editable sortable renderable id">2</td></tr>' +
33+
'<tr><td class="integer-cell editable sortable renderable id">1</td></tr>' +
34+
'<tr><td class="integer-cell editable sortable renderable id">3</td></tr>');
3535
});
3636

3737
it("will render a new row if a new model is added to its collection", function () {
@@ -41,15 +41,15 @@ describe("A Body", function () {
4141
var $trs = body.$el.children();
4242
expect($trs.length).toBe(4);
4343
expect($("<div>").append($trs.eq(3).clone()).html().toLowerCase().replace(/\s*</g, '<'))
44-
.toBe('<tr><td class="integer-cell editable sortable renderable">4</td></tr>');
44+
.toBe('<tr><td class="integer-cell editable sortable renderable id">4</td></tr>');
4545

4646
body.collection.add({
4747
id: 5
4848
}, {at: 1});
4949
$trs = body.$el.children();
5050
expect($trs.length).toBe(5);
5151
expect($("<div>").append($trs.eq(1).clone()).html().toLowerCase().replace(/\s*</g, '<'))
52-
.toBe('<tr><td class="integer-cell editable sortable renderable">5</td></tr>');
52+
.toBe('<tr><td class="integer-cell editable sortable renderable id">5</td></tr>');
5353
});
5454

5555
it("will render a new row by calling insertRow directly with a new model", function () {
@@ -71,15 +71,15 @@ describe("A Body", function () {
7171
var $trs = body.$el.children();
7272
expect($trs.length).toBe(1);
7373
expect($("<div>").append($trs.eq(0).clone()).html().toLowerCase().replace(/\s*</g, '<'))
74-
.toBe('<tr><td class="integer-cell editable sortable renderable">4</td></tr>');
74+
.toBe('<tr><td class="integer-cell editable sortable renderable id">4</td></tr>');
7575

7676
body.insertRow({
7777
id: 5
7878
}, {at: 0});
7979
$trs = body.$el.children();
8080
expect($trs.length).toBe(2);
8181
expect($("<div>").append($trs.eq(0).clone()).html().toLowerCase().replace(/\s*</g, '<'))
82-
.toBe('<tr><td class="integer-cell editable sortable renderable">5</td></tr>');
82+
.toBe('<tr><td class="integer-cell editable sortable renderable id">5</td></tr>');
8383
});
8484

8585
it("will remove a row from the DOM if a model is removed from its collection", function () {
@@ -88,8 +88,8 @@ describe("A Body", function () {
8888
var $trs = body.$el.children();
8989
expect($trs.length).toBe(2);
9090
expect($(body.el).html().toLowerCase().replace(/\s+</g, '<'))
91-
.toBe('<tr><td class="integer-cell editable sortable renderable">2</td></tr>' +
92-
'<tr><td class="integer-cell editable sortable renderable">3</td></tr>');
91+
.toBe('<tr><td class="integer-cell editable sortable renderable id">2</td></tr>' +
92+
'<tr><td class="integer-cell editable sortable renderable id">3</td></tr>');
9393
});
9494

9595
it("will remove a row from the DOM is removeRow is called directly with a model", function () {
@@ -98,8 +98,8 @@ describe("A Body", function () {
9898
var $trs = body.$el.children();
9999
expect($trs.length).toBe(2);
100100
expect($(body.el).html().toLowerCase().replace(/\s+</g, '<'))
101-
.toBe('<tr><td class="integer-cell editable sortable renderable">2</td></tr>' +
102-
'<tr><td class="integer-cell editable sortable renderable">3</td></tr>');
101+
.toBe('<tr><td class="integer-cell editable sortable renderable id">2</td></tr>' +
102+
'<tr><td class="integer-cell editable sortable renderable id">3</td></tr>');
103103
});
104104

105105
it("will refresh if its collection is reset", function () {
@@ -116,7 +116,7 @@ describe("A Body", function () {
116116
var $trs = body.$el.children();
117117
expect($trs.length).toBe(1);
118118
expect($(body.el).html().toLowerCase().replace(/\s+</g, '<'))
119-
.toBe('<tr><td class="integer-cell editable sortable renderable">6</td></tr>');
119+
.toBe('<tr><td class="integer-cell editable sortable renderable id">6</td></tr>');
120120
});
121121

122122
it("will render rows using the Row class supplied in the constructor options", function () {

0 commit comments

Comments
 (0)