Skip to content

Commit 3b2afd4

Browse files
Forest Eckhardtarjun024
authored andcommitted
Updates miniconda name to miniforge
1 parent 8eb9cb0 commit 3b2afd4

9 files changed

Lines changed: 21 additions & 20 deletions

File tree

manifest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ dependencies:
4343
sha256: '009a3476197030e30d0ce924cc044ee4851ef27324e132b29fd12d8cde071915'
4444
source: https://launchpad.net/libmemcached/1.0/1.0.18/+download/libmemcached-1.0.18.tar.gz
4545
source_sha256: e22c0bb032fde08f53de9ffbc5a128233041d9f33b5de022c0978a2149885f82
46-
- name: miniconda3-py39
46+
- name: miniforge
4747
version: 24.7.1
4848
uri: https://github.com/conda-forge/miniforge/releases/download/24.7.1-0/Miniforge3-24.7.1-0-Linux-x86_64.sh
4949
sha256: b64f77042cf8eafd31ced64f9253a74fb85db63545fe167ba5756aea0e8125be

src/python/conda/conda.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,29 +70,29 @@ func Run(c *Conda) error {
7070
}
7171

7272
func (c *Conda) Version() string {
73-
return "miniconda3-py39"
73+
return "miniforge"
7474
}
7575

7676
func (c *Conda) Install(version string) error {
7777
c.Log.BeginStep("Supplying conda")
7878
var installer string
79-
if installerDir, err := os.MkdirTemp("", "miniconda"); err != nil {
79+
if installerDir, err := os.MkdirTemp("", "miniforge"); err != nil {
8080
return err
8181
} else {
82-
installer = filepath.Join(installerDir, "miniconda.sh")
82+
installer = filepath.Join(installerDir, "miniforge.sh")
8383
defer os.RemoveAll(installerDir)
8484
}
8585

8686
if err := c.Installer.InstallOnlyVersion(version, installer); err != nil {
87-
return fmt.Errorf("Error downloading miniconda: %v", err)
87+
return fmt.Errorf("Error downloading miniforge: %v", err)
8888
}
8989
if err := os.Chmod(installer, 0755); err != nil {
9090
return err
9191
}
9292

93-
c.Log.BeginStep("Installing Miniconda")
93+
c.Log.BeginStep("Installing Miniforge")
9494
if err := c.Command.Execute("/", indentWriter(os.Stdout), io.Discard, installer, "-b", "-p", c.condaHome()); err != nil {
95-
return fmt.Errorf("Error installing miniconda: %v", err)
95+
return fmt.Errorf("Error installing miniforge: %v", err)
9696
}
9797

9898
return nil

src/python/conda/conda_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,14 @@ var _ = Describe("Conda", func() {
7272
Expect(os.WriteFile(filepath.Join(buildDir, "runtime.txt"), []byte("python-3.2.3"), 0644)).To(Succeed())
7373
})
7474

75-
It("returns 'miniconda3-py39'", func() {
76-
Expect(subject.Version()).To(Equal("miniconda3-py39"))
75+
It("returns 'miniforge'", func() {
76+
Expect(subject.Version()).To(Equal("miniforge"))
7777
})
7878
})
7979

8080
Context("runtime.txt does not exist", func() {
81-
It("returns 'miniconda3-py39'", func() {
82-
Expect(subject.Version()).To(Equal("miniconda3-py39"))
81+
It("returns 'miniforge'", func() {
82+
Expect(subject.Version()).To(Equal("miniforge"))
8383
})
8484
})
8585
})

src/python/integration/init_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@ package integration_test
33
import (
44
"flag"
55
"fmt"
6-
"github.com/onsi/gomega/types"
76
"io"
87
"net/http"
98
"os"
109
"path/filepath"
1110
"testing"
1211
"time"
1312

13+
"github.com/onsi/gomega/types"
14+
1415
"github.com/cloudfoundry/switchblade"
1516
"github.com/onsi/gomega/format"
1617
"github.com/sclevine/spec"
@@ -102,7 +103,7 @@ func TestIntegration(t *testing.T) {
102103
suite("Versions", testVersions(platform, fixtures, root))
103104
suite("Miscellaneous", testMiscellaneous(platform, fixtures))
104105
suite("Django", testDjango(platform, fixtures))
105-
suite("Miniconda", testMiniconda(platform, fixtures))
106+
suite("Miniforge", testMiniforge(platform, fixtures))
106107
suite("Pipenv", testPipenv(platform, fixtures))
107108
suite("Override", testOverride(platform, fixtures))
108109
suite("Multibuildpack", testMultibuildpack(platform, fixtures))
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import (
1313
. "github.com/onsi/gomega"
1414
)
1515

16-
func testMiniconda(platform switchblade.Platform, fixtures string) func(*testing.T, spec.G, spec.S) {
16+
func testMiniforge(platform switchblade.Platform, fixtures string) func(*testing.T, spec.G, spec.S) {
1717
return func(t *testing.T, context spec.G, it spec.S) {
1818
var (
1919
Expect = NewWithT(t).Expect
@@ -32,12 +32,12 @@ func testMiniconda(platform switchblade.Platform, fixtures string) func(*testing
3232
Expect(platform.Delete.Execute(name)).To(Succeed())
3333
})
3434

35-
context("when pushing an app that uses miniconda 3", func() {
35+
context("when pushing an app that uses miniforge", func() {
3636
var source string
3737
context("when environment.yml stays the same", func() {
3838
it.Before(func() {
3939
var err error
40-
source, err = switchblade.Source(filepath.Join(fixtures, "miniconda"))
40+
source, err = switchblade.Source(filepath.Join(fixtures, "miniforge"))
4141
Expect(err).NotTo(HaveOccurred())
4242
})
4343

@@ -53,7 +53,7 @@ func testMiniconda(platform switchblade.Platform, fixtures string) func(*testing
5353
Eventually(deployment).Should(Serve(ContainSubstring("gunicorn: 20.1.0")))
5454

5555
Expect(logs.String()).To(SatisfyAll(
56-
ContainSubstring("Installing Miniconda"),
56+
ContainSubstring("Installing Miniforge"),
5757
ContainSubstring("Installing conda environment from environment.yml"),
5858
))
5959
})
@@ -62,7 +62,7 @@ func testMiniconda(platform switchblade.Platform, fixtures string) func(*testing
6262
context("when environment.yml changes", func() {
6363
it.Before(func() {
6464
var err error
65-
source, err = switchblade.Source(filepath.Join(fixtures, "miniconda"))
65+
source, err = switchblade.Source(filepath.Join(fixtures, "miniforge"))
6666
Expect(err).NotTo(HaveOccurred())
6767
})
6868

@@ -81,7 +81,7 @@ func testMiniconda(platform switchblade.Platform, fixtures string) func(*testing
8181
)))
8282

8383
Expect(logs.String()).To(SatisfyAll(
84-
ContainSubstring("Installing Miniconda"),
84+
ContainSubstring("Installing Miniforge"),
8585
ContainSubstring("Installing conda environment from environment.yml"),
8686
))
8787

@@ -102,7 +102,7 @@ func testMiniconda(platform switchblade.Platform, fixtures string) func(*testing
102102
)))
103103

104104
Expect(logs.String()).To(SatisfyAll(
105-
ContainSubstring("Installing Miniconda"),
105+
ContainSubstring("Installing Miniforge"),
106106
ContainSubstring("Installing conda environment from environment.yml"),
107107
))
108108
})

0 commit comments

Comments
 (0)