RD-6060 - Changes for Vault Secrets Provider (#1458)

Author: Adrian Polanczyk

cloudify_cli/cli/cfy.py

@@ -1900,6 +1900,7 @@ def __init__(self):
         )
 
         self.provider = click.option(
+            '-p',
             '--provider',
             'provider',
             required=False,
@@ -2499,22 +2500,32 @@ def deployment_filter_rules(self, f):
         return self._filter_rules(f, 'deployment')
 
     @staticmethod
-    def secret_provider_type(required=True, _help=None):
+    def secret_provider_type(
+            required=True,
+            _help=None,
+            default=None,
+            callback=validate_value_not_empty,
+    ):
         args = [
+            '-y',
             '--type',
             'secret_provider_type',
         ]
         kwargs = {
             'required': required,
             'help': _help or helptexts.SECRET_PROVIDER_TYPE,
-            'callback': validate_value_not_empty,
+            'callback': callback,
         }
 
+        if default is not None:
+            kwargs['default'] = default
+
         return click.option(*args, **kwargs)
 
     @staticmethod
     def connection_parameters(required=True, _help=None, default=None):
         args = [
+            '-c',
             '--connection-parameters',
         ]
         kwargs = {
@@ -2530,6 +2541,7 @@ def connection_parameters(required=True, _help=None, default=None):
     @staticmethod
     def provider_multiple(required=False, _help=None, default=None):
         args = [
+            '-p',
             '--provider',
             'provider',
         ]

cloudify_cli/commands/secrets.py

@@ -46,7 +46,6 @@
 SECRET_PROVIDER_COLUMNS = [
     'name',
     'type',
-    'connection_parameters',
     'visibility',
     'tenant_name',
     'created_by',
@@ -473,10 +472,18 @@ def providers_create(
     )
 
     logger.info(
-        'Secret provider `%s` created',
+        'Secrets Provider `%s` created',
         secret_provider_name,
     )
 
+    client.secrets_providers.check(
+        name=secret_provider_name,
+    )
+
+    logger.info(
+        'Connected to the Secrets Provider successfully',
+    )
+
 
 @providers.command(
     name='update',
@@ -610,6 +617,56 @@ def providers_list(
     )
 
 
+@providers.command(
+    name='test',
+    short_help='Test a Secrets Provider connectivity',
+)
+@cfy.argument(
+    'secret_provider_name',
+    required=False,
+    default='',
+)
+@cfy.options.secret_provider_type(
+    required=False,
+    default='',
+    callback=None,
+)
+@cfy.options.connection_parameters(
+    required=False,
+)
+@cfy.options.tenant_name(
+    required=False,
+    resource_name_for_help='secret_provider',
+)
+@cfy.options.visibility(
+    mutually_exclusive_required=False,
+)
+@cfy.options.common_options
+@cfy.assert_manager_active()
+@cfy.pass_client(
+    use_tenant_in_header=True,
+)
+@cfy.pass_logger
+def providers_test(
+        secret_provider_name,
+        secret_provider_type,
+        connection_parameters,
+        tenant_name,
+        visibility,
+        logger,
+        client,
+):
+    client.secrets_providers.check(
+        name=secret_provider_name,
+        _type=secret_provider_type,
+        connection_parameters=connection_parameters,
+    )
+
+    logger.info(
+        'Connected to the Secrets Provider successfully',
+    )
+
+
 def _get_secret_string(secret_file, secret_string):
     if secret_file:
         if not os.path.exists(secret_file):