Skip to content

Commit 05ba88c

Browse files
committed
chore(greenhouse): apply review
1 parent ba72ea4 commit 05ba88c

1 file changed

Lines changed: 4 additions & 11 deletions

File tree

apps/greenhouse/src/components/admin/common/ReconcileButton.tsx

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,20 +44,13 @@ export const ReconcileButton: React.FC<ReconcileButtonProps> = ({
4444
onReconcile?.()
4545
},
4646
onError: (error) => {
47-
let errorMessage = "Unknown error"
48-
if (error instanceof Error) {
49-
errorMessage = error.message
50-
} else if (typeof error === "string") {
51-
errorMessage = error
52-
}
47+
const normalizedError = error instanceof Error ? error : new Error("Unknown error")
48+
5349
addMessage({
5450
variant: "error",
55-
text: `Failed to reconcile ${resourceType} "${resourceName}": ${errorMessage}`,
51+
text: `Failed to reconcile ${resourceType} "${resourceName}": ${normalizedError.message}`,
5652
})
57-
if (onError) {
58-
const errorForCallback = error instanceof Error ? error : new Error(errorMessage)
59-
onError(errorForCallback)
60-
}
53+
onError?.(normalizedError)
6154
},
6255
})
6356

0 commit comments

Comments
 (0)