chore(kubernetes): fix tests and lint issues

Author: andypf

packages/k8s-client/src/client.ts

@@ -17,15 +17,15 @@ interface ClientOptions {
 }
 
 function createClient(options: ClientOptions) {
-  const { apiEndpoint, ignoreSsl = false } = options
+  const { apiEndpoint, ignoreSsl = false, debug = false } = options
   let token = options.token
 
   if (!apiEndpoint || !token) {
     throw new Error(`Bad options: ${JSON.stringify(options, null, 4)}. Please provide apiEndpoint and token`)
   }
 
   // Log warning when SSL verification is disabled
-  if (ignoreSsl && options.debug === true) {
+  if (ignoreSsl && debug === true) {
     console.warn(`⚠️  K8s Client: SSL certificate verification disabled for ${apiEndpoint}`)
     console.warn(`🔒 This should only be used in development or secure internal networks`)
   }
@@ -43,6 +43,8 @@ function createClient(options: ClientOptions) {
     }
 
     return {
+      debug,
+      ignoreSsl,
       ...defaultOptions,
       ...options,
       headers,

packages/k8s-client/src/request.ts

@@ -49,6 +49,7 @@ function request(method: string, url: string, options: RequestOptions = {}): Pro
 
   // Create HTTPS agent if SSL should be ignored for HTTPS URLs
   let agent: https.Agent | undefined
+
   if (ignoreSsl && url.startsWith("https:") && typeof window === "undefined") {
     agent = new https.Agent({
       rejectUnauthorized: false,

packages/k8s-client/test/client.test.ts

@@ -327,6 +327,7 @@ describe("k8sClient", () => {
     })
 
     test("should pass ignoreSsl to request when making HTTP calls", async () => {
+      globalThis.window = undefined!
       const client = createClient({
         apiEndpoint: "https://internal-k8s.company.com",
         token: "test-token",
@@ -350,6 +351,7 @@ describe("k8sClient", () => {
     })
 
     test("should allow per-request SSL override", async () => {
+      globalThis.window = undefined!
       const client = createClient({
         apiEndpoint: "https://k8s-api.company.com",
         token: "test-token",

packages/k8s-client/test/request.test.ts

@@ -108,6 +108,7 @@ describe("request", () => {
 
   describe("Request Options", () => {
     test("provide only allowed options to fetch", async () => {
+      globalThis.window = undefined!
       await request("GET", testUrl, {
         signal: "test" as unknown as AbortSignal,
         headers: { key1: "value1" },
@@ -159,6 +160,7 @@ describe("request", () => {
 
   describe("SSL Ignore Functionality", () => {
     test("should create HTTPS agent when ignoreSsl is true for HTTPS URL", async () => {
+      globalThis.window = undefined!
       await request("GET", testUrl, {
         ignoreSsl: true,
         headers: { Authorization: "Bearer token" },
@@ -221,6 +223,7 @@ describe("request", () => {
     })
 
     test("should filter out ignoreSsl from fetch options", async () => {
+      globalThis.window = undefined!
       await request("POST", testUrl, {
         body: { data: "test" },
         headers: { "Content-Type": "application/json" },
@@ -235,6 +238,7 @@ describe("request", () => {
     })
 
     test("should handle mixed requests with different SSL settings", async () => {
+      globalThis.window = undefined!
       // First request with SSL verification (default)
       await request("GET", testUrl, {
         headers: { Accept: "application/json" },
@@ -262,6 +266,7 @@ describe("request", () => {
     test("should work with all HTTP methods and ignoreSsl", async () => {
       const methods = ["GET", "POST", "PUT", "PATCH", "DELETE", "HEAD"]
       const testBody = { test: "data" }
+      globalThis.window = undefined!
 
       for (const method of methods) {
         vi.clearAllMocks()
@@ -293,6 +298,7 @@ describe("request", () => {
     })
 
     test("should handle JSON body serialization with ignoreSsl", async () => {
+      globalThis.window = undefined!
       const requestBody = {
         name: "test-resource",
         spec: { replicas: 3 },
@@ -315,6 +321,7 @@ describe("request", () => {
     })
 
     test("should handle string body without modification with ignoreSsl", async () => {
+      globalThis.window = undefined!
       const stringBody = "raw string data"
 
       await request("POST", testUrl, {
@@ -331,6 +338,7 @@ describe("request", () => {
     })
 
     test("should handle URL parameters with ignoreSsl", async () => {
+      globalThis.window = undefined!
       await request("GET", testUrl, {
         params: {
           labelSelector: "app=nginx",