Merge branch 'main' into ci/add-npm-publish-workflow

Author: hodanoori

.github/workflows/release.yaml

@@ -25,7 +25,7 @@ jobs:
     steps:
       - name: Generate GitHub App Token
         id: github-app-token
-        uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf # v2
+        uses: actions/create-github-app-token@fee1f7d63c2ff003460e3d139729b119787bc349 # v2
         with:
           app-id: ${{ secrets.CLOUDOPERATOR_APP_ID }}
           private-key: ${{ secrets.CLOUDOPERATOR_APP_PRIVATE_KEY }}

apps/greenhouse/src/components/core-apps/org-admin/components/clusters/hooks/useApi.ts

@@ -17,8 +17,6 @@ export const useApi = (debug?: boolean) => {
 
   const get = useCallback(
     async <T extends AllowedApiObject>(url: string, object: T, params?: any): Promise<ApiResponse> => {
-      let response: T
-
       if (!client || !namespace) {
         return { ok: false, message: "Client or namespace not available" }
       }

apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugindefinitions/hooks/useApi.ts

@@ -17,8 +17,6 @@ export const useApi = (debug?: boolean) => {
 
   const get = useCallback(
     async <T extends AllowedApiObject>(url: string, object: T, params?: any): Promise<ApiResponse> => {
-      let response: T
-
       if (!client || !namespace) {
         return { ok: false, message: "Client or namespace not available" }
       }

apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugindefinitions/hooks/usePluginPresetApi.ts

@@ -17,7 +17,6 @@ export type PluginPresetApiResponse = {
 export const usePluginPresetApi = () => {
   const { get, create, update, deleteObject } = useApi()
   const namespace = useStore((state: any) => state.namespace)
-  const { client } = useClient()
 
   const getPluginPreset = (pluginPreset: PluginPreset): Promise<PluginPresetApiResponse> => {
     return get<PluginPreset>(

apps/supernova/src/lib/createAlertsSlice.test.tsx

@@ -4,7 +4,7 @@
  */
 
 import * as React from "react"
-import { renderHook, act } from "@testing-library/react"
+import { renderHook } from "@testing-library/react"
 import {
   useAlertsActions,
   useAlertEnrichedLabels,

packages/url-state-provider/src/v2/encode.spec.ts

@@ -22,19 +22,32 @@ describe("encode", () => {
   })
 
   describe("returns empty string for non-object values", () => {
-    it.each`
-      description                    | input
-      ${"not an object (null)"}      | ${null}
-      ${"not an object (undefined)"} | ${undefined}
-      ${"not an object (true)"}      | ${true}
-      ${"not an object (false)"}     | ${false}
-      ${"not an object (number)"}    | ${1}
-      ${"not an object (string)"}    | ${"string"}
-      ${"is an empty object"}        | ${{}}
-      ${"a regular expression"}      | ${/regexp/}
-      ${"an array"}                  | ${[1, 2, 3]}
-    `("returns '' when input is $description", ({ input }) => {
-      expect(encode(input)).toBe("")
+    it("returns '' when input is not an object (null)", () => {
+      expect(encode(null as any)).toBe("")
+    })
+    it("returns '' when input is not an object (undefined)", () => {
+      expect(encode(undefined as any)).toBe("")
+    })
+    it("returns '' when input is not an object (true)", () => {
+      expect(encode(true as any)).toBe("")
+    })
+    it("returns '' when input is not an object (false)", () => {
+      expect(encode(false as any)).toBe("")
+    })
+    it("returns '' when input is not an object (number)", () => {
+      expect(encode(1 as any)).toBe("")
+    })
+    it("returns '' when input is not an object (string)", () => {
+      expect(encode("string" as any)).toBe("")
+    })
+    it("returns '' when input is an empty object", () => {
+      expect(encode({})).toBe("")
+    })
+    it("returns '' when input is a regular expression", () => {
+      expect(encode(/regexp/ as any)).toBe("")
+    })
+    it("returns '' when input is an array", () => {
+      expect(encode([1, 2, 3] as any)).toBe("")
     })
   })