chore(heureka): enable no-unused-vars rule (#1204)

Author: taymoor89

apps/heureka/eslint.config.mjs

@@ -16,10 +16,10 @@ export default [
     rules: {
       "prefer-const": "off",
       "no-unused-vars": "off",
+      "@typescript-eslint/no-unused-vars": "error",
       "no-extra-boolean-cast": "off",
       "react/prop-types": "off",
       "react/react-in-jsx-scope": "off",
-      "react/no-unused-vars": "off",
       "react-hooks/rules-of-hooks": "error",
       "react-hooks/exhaustive-deps": "off",
       "tailwindcss/classnames-order": "off",
@@ -39,6 +39,6 @@ export default [
       "@typescript-eslint/require-await": "off",
       "@typescript-eslint/no-unsafe-argument": "off",
     },
-    ignores: ["vitest.config.ts", "vite.config.ts", "vitest.setup.ts", "tailwind.config.ts"],
+    ignores: ["vitest.config.ts", "vite.config.ts", "vitest.setup.ts", "tailwind.config.ts", "**/routeTree.gen.ts"],
   },
 ]

apps/heureka/src/components/Services/ServicesList/ServicePanel.tsx

@@ -32,6 +32,7 @@ export const ServicePanel = () => {
     navigate({
       to: "/services",
       search: (prev) => {
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const { service, ...rest } = prev
         return { ...rest }
       },

apps/heureka/src/components/Vulnerabilities/Vulnerabilities.test.tsx

@@ -10,7 +10,7 @@ import { PortalProvider } from "@cloudoperators/juno-ui-components/index"
 import { Vulnerabilities } from "./index"
 import { Filter, FilterSettings } from "../common/Filters/types"
 import { getTestRouter } from "../../mocks/getTestRouter"
-import { mockVulnerabilitiesPromise, mockVulnerabilityFiltersPromise } from "../../mocks/promises"
+import { mockVulnerabilitiesPromise } from "../../mocks/promises"
 
 const mockFilters: Filter[] = [
   {

apps/heureka/src/components/Vulnerabilities/VulnerabilitiesList/VulnerabilityDetailsPanel/VulnerabilityServicesTotalCount.tsx

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import React, { use } from "react"
+import { use } from "react"
 import { Vulnerability } from "../../utils"
 import { ApolloQueryResult } from "@apollo/client"
 import { GetVulnerabilitiesQuery } from "../../../../generated/graphql"

apps/heureka/src/components/Vulnerabilities/VulnerabilitiesList/VulnerabilityDetailsPanel/index.tsx

@@ -22,7 +22,7 @@ export const VulnerabilityPanel = () => {
   const navigate = useNavigate()
   const { queryClient, apiClient } = useRouteContext({ from: "/vulnerabilities/" })
   const { vulnerability } = useSearch({ from: "/vulnerabilities/" })
-  const [currentServicesCursor, setCurrentServicesCursor] = useState<string | null | undefined>(undefined)
+  const [currentServicesCursor] = useState<string | null | undefined>(undefined)
 
   // Create a stable promise for vulnerability details (including support groups)
   // This promise doesn't change when pagination happens
@@ -69,7 +69,8 @@ export const VulnerabilityPanel = () => {
     navigate({
       to: "/vulnerabilities",
       search: (prev) => {
-        const { vulnerability, ...rest } = prev
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
+        const { vulnerability, ...rest } = prev // we're omitting 'vulnerability' from the deps so route does not reload when it changes
         return { ...rest }
       },
     })

apps/heureka/src/components/common/ErrorBoundary/index.test.tsx

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import React, { useEffect, ReactElement } from "react"
+import React, { useEffect } from "react"
 import { render, screen } from "@testing-library/react"
 import { ErrorBoundary } from "./index"
 

apps/heureka/src/components/common/Filters/index.tsx

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import React, { useCallback, useEffect } from "react"
+import React, { useCallback } from "react"
 import { Button, InputGroup, SearchInput, Stack } from "@cloudoperators/juno-ui-components"
 import { FilterSelect } from "./FilterSelect"
 import { Filter, FilterSettings, SelectedFilter } from "./types"

apps/heureka/src/components/common/Navigation.tsx

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import React, { ReactNode, useRef } from "react"
+import React, { useRef } from "react"
 import { TopNavigation, TopNavigationItem } from "@cloudoperators/juno-ui-components"
 import { useNavigate, useLocation } from "@tanstack/react-router"
 
@@ -13,11 +13,6 @@ type NavigationItemType = {
   path: string
 }
 
-type NavigationPropsType = {
-  activeItem?: ReactNode
-  onChange?: (value: ReactNode) => void
-}
-
 const navigationItems: NavigationItemType[] = [
   {
     label: "Services",
@@ -31,7 +26,7 @@ const navigationItems: NavigationItemType[] = [
   },
 ]
 
-export const Navigation = ({ activeItem }: NavigationPropsType) => {
+export const Navigation = () => {
   const navigate = useNavigate()
   const location = useLocation()
   const isVulnerabilitiesActive = location.pathname.toLowerCase().includes("vulnerabilities")

apps/heureka/src/components/common/SeverityCount.tsx

@@ -11,7 +11,6 @@ import {
   TooltipContent,
   KnownIcons,
   BadgeVariantType,
-  Icon,
 } from "@cloudoperators/juno-ui-components"
 
 type SeverityCountProps = {

apps/heureka/src/routes/services/$service.tsx

@@ -6,7 +6,6 @@
 import { createFileRoute } from "@tanstack/react-router"
 import { z } from "zod"
 import { Service } from "../../components/Service"
-import { LoaderWithCrumb } from "../-types"
 import { fetchService } from "../../api/fetchService"
 
 const serviceSearchSchema = z.object({
@@ -17,7 +16,8 @@ export const Route = createFileRoute("/services/$service")({
   validateSearch: serviceSearchSchema,
   shouldReload: false,
   loaderDeps: ({ search }) => {
-    const { imageVersion, ...rest } = search
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    const { imageVersion, ...rest } = search // we're omitting 'imageVersion' from the deps so route does not reload when it changes
     return { ...rest }
   },
   loader: ({ context, params: { service } }) => {