fix(apps): resolve CodeQL static analysis warnings across codebase (#1557)

* chore(apps): fix comparison between inconvertible types

* chore(apps): fix comparison between inconvertible types

* chore(apps): fix implicit operand conversion

* fix(apps): remove redundant conditional expressions

* fix(apps): remove useless expressions and fix zustand set call syntax

* fix(apps): remove duplicate namespace property in teams store

* fix(apps): declare errMsg as local variable in parseError function

* fix(greenhouse): remove unused variable in JSON validation function

* chore(ci): adds changeset

* chore(apps): fix link

* chore(supernova): fix lint

* chore(ui): fix test

* chore(supernova): fix comparation

* chore(ci): adapt changeset

* chore(supernova): remove as

Author: ArtieReus

.changeset/beige-ravens-find.md

@@ -0,0 +1,8 @@
+---
+"@cloudoperators/juno-ui-components": patch
+"@cloudoperators/juno-app-greenhouse": patch
+"@cloudoperators/juno-app-supernova": patch
+"@cloudoperators/juno-app-doop": patch
+---
+
+Resolves all CodeQL static analysis warnings to improve code quality, reliability, and maintainability. These fixes address potential bugs, redundant code, and anti-patterns detected by automated code scanning.

apps/doop/src/components/Highlighter.tsx

@@ -120,8 +120,7 @@ const Highlighter = () => {
   React.useEffect(() => {
     const observers = createObservers((mutations: any) => {
       for (const mutation of mutations) {
-        // @ts-expect-error TS(2367) FIXME: This condition will always return 'false' since th... Remove this comment to see the full error message
-        if (!mutation.type === "childList") continue
+        if (mutation.type !== "childList") continue
 
         // ignore changes to search nodes
         const addedOrRemovedNodes = Array.from(mutation.addedNodes).concat(Array.from(mutation.removedNodes))

apps/doop/src/lib/filterViolations.ts

@@ -85,7 +85,7 @@ const filterByActiveFilters = (violationGroups: any[], clusterIdentities: any[],
             true
           )
         )
-        found = found && constraint.violation_groups?.length > 0
+        found = (constraint.violation_groups?.length ?? 0) > 0
       }
 
       // ############ CLUSTER FILTERS ############

apps/greenhouse/src/components/core-apps/org-admin/components/clusters/components/ClusterEdit.tsx

@@ -23,7 +23,6 @@ import { useClusterApi } from "../hooks/useClusterApi"
 
 const ClusterEdit: React.FC<any> = () => {
   const clusterInEdit = useStore((state: any) => state.clusterInEdit)
-  clusterInEdit?.spec
   const setClusterInEdit = useStore((state: any) => state.setClusterInEdit)
 
   const [submitMessage, setSubmitResultMessage] = React.useState<ResultMessage>({ message: "", ok: false })

apps/greenhouse/src/components/core-apps/org-admin/components/plugins/plugin-edit/OptionInput.tsx

@@ -21,9 +21,8 @@ export const OptionInput: React.FC<OptionInputProps> = (props: OptionInputProps)
   const [errortext, setErrorText] = useState<string>("")
 
   const handleJsonValidation = (value: string) => {
-    let object
     try {
-      object = JSON.parse(value)
+      JSON.parse(value)
     } catch (e) {
       setValid(false)
       setErrorText("Invalid JSON")

apps/greenhouse/src/components/core-apps/org-admin/components/teams/lib/store.ts

@@ -14,8 +14,6 @@ export default () =>
     currentTeam: "",
     defaultTeam: "",
     teamMemberships: [],
-    // @ts-expect-error TS(1117): An object literal cannot have multiple properties ... Remove this comment to see the full error message
-    namespace: "",
 
     actions: {
       initialize: (endpoint: any, token: any, namespace: any, userGroup: any) =>

apps/greenhouse/src/lib/helpers.ts

@@ -4,18 +4,15 @@
  */
 
 export const parseError = (error: any) => {
+  let errMsg: string
   if (error?.message) {
-    // @ts-expect-error TS(2304): Cannot find name 'errMsg'.
     errMsg = error?.message
     try {
-      // @ts-expect-error TS(2304): Cannot find name 'errMsg'.
       errMsg = JSON.parse(error?.message).msg
     } catch (error) {
       console.debug(error)
     }
-    // @ts-expect-error TS(2304): Cannot find name 'errMsg'.
   } else errMsg = error.toString()
-  // @ts-expect-error TS(2304): Cannot find name 'errMsg'.
   return errMsg
 }
 

apps/supernova/src/components/alerts/AlertStatus.tsx

@@ -41,7 +41,7 @@ const AlertStatus = ({ alert }: any) => {
 
   return (
     <div className="cursor-default">
-      {alert && <span>{alert?.status?.state}</span>}
+      {alert?.status?.state && <span>{alert.status.state}</span>}
       {inhibitor && (
         <div className="text-xs mt-2">
           <Stack direction="vertical">

apps/supernova/src/lib/createFiltersSlice.tsx

@@ -66,18 +66,20 @@ const parsePredefinedFilters = (predefinedFilters: any[]): FilterState["predefin
 }
 
 const parseInitialFilters = (
-  initialFilters: Record<string, string[]>,
+  initialFilters: Record<string, string[]> | null | undefined,
   filterLabels: string[]
 ): Record<string, string[]> => {
   if (!initialFilters) return {}
 
-  if (typeof initialFilters !== "object" || initialFilters === null) {
+  if (typeof initialFilters !== "object" || Array.isArray(initialFilters)) {
     console.warn("[supernova]::parseInitialFilters: initialFilters object is not an object")
     return {}
   }
 
+  const validatedFilters: Record<string, string[]> = initialFilters
+
   // Check if all values are arrays
-  initialFilters = Object.entries(initialFilters).reduce((acc: any, [key, value]) => {
+  const filteredByType = Object.entries(validatedFilters).reduce((acc: Record<string, string[]>, [key, value]) => {
     if (Array.isArray(value)) {
       acc[key] = value // valid key-value pair
     } else {
@@ -87,25 +89,25 @@ const parseInitialFilters = (
   }, {})
 
   // Check if all keys are in filterLabelValues
-  if (!Object.keys(initialFilters).every((key) => filterLabels.includes(key))) {
+  if (!Object.keys(filteredByType).every((key) => filterLabels.includes(key))) {
     console.warn(
       "[supernova]::parseInitialFilters: Some keys of the initialFilters object are not valid filter labels. They must be configured as filterLabels first. Using only valid keys."
     )
 
     // filter out the keys that are not in filterLabels, return the rest
     // this will ensure that at least the valid keys are used as initial filters
-    const filtered = Object.keys(initialFilters)
+    const filtered = Object.keys(filteredByType)
       .filter((key) => filterLabels.includes(key))
-      .reduce((obj, key) => {
+      .reduce<Record<string, string[]>>((obj, key) => {
         return {
           ...obj,
-          [key]: initialFilters[key],
+          [key]: filteredByType[key],
         }
       }, {})
     return filtered
   }
 
-  return initialFilters
+  return filteredByType
 }
 
 const parseActivePredefinedFilter = (predefinedFilters: any): string | null => {

apps/supernova/src/lib/createSilencesSlice.tsx

@@ -163,14 +163,16 @@ const createSilencesSlice: (options?: Record<string, any>) => StateCreator<AppSt
 
         setSilences: ({ items }) => {
           if (!items) return
-          ;(set((state: any) => ({
-            silences: {
-              ...state.silences,
-              items: items,
-              updatedAt: Date.now(),
-            },
-          })),
-            false)
+          set(
+            (state: any) => ({
+              silences: {
+                ...state.silences,
+                items: items,
+                updatedAt: Date.now(),
+              },
+            }),
+            false
+          )
         },
 
         /*