fix(juno): prevent apps from crash when there are no initialFilters

Author: taymoor89

apps/doop/src/lib/helpers.ts

@@ -36,3 +36,6 @@ export function capitalize(string: any) {
   // Capitalize the first character and concatenate it with the rest of the string
   return string.charAt(0).toUpperCase() + string.slice(1)
 }
+
+export const isObjectWithKeys = (value: any) =>
+  value !== null && typeof value === "object" && Object.keys(value).length > 0

apps/doop/src/routes/violations.tsx

@@ -16,6 +16,7 @@ import {
   useGlobalsInitialFiltersApplied,
 } from "../components/StoreProvider"
 import { parseInitialFilters } from "../lib/store/createFiltersSlice"
+import { isObjectWithKeys } from "../lib/helpers"
 
 const searchSchema = z
   .object({
@@ -79,7 +80,7 @@ function RouteComponent() {
    * */
   useLayoutEffect(() => {
     // we only want to apply initial filters only once when url does not contain any filter
-    if (!isUrlRead && Object.keys(activeFilters).length === 0 && Object.keys(initialFilters || {}).length > 0) {
+    if (!isUrlRead && !isObjectWithKeys(activeFilters) && isObjectWithKeys(initialFilters)) {
       setIsUrlRead()
       navigate({
         to: "/violations",

apps/supernova/src/lib/utils.ts

@@ -137,3 +137,6 @@ export const sortAlerts = (items: any) => {
     else return 1
   })
 }
+
+export const isObjectWithKeys = (value: any) =>
+  value !== null && typeof value === "object" && Object.keys(value).length > 0

apps/supernova/src/routes/alerts.tsx

@@ -13,6 +13,7 @@ import AlertsTab from "../components/alerts/AlertsTab"
 import { ACTIVE_FILTERS_PREFIX, PAUSED_FILTERS_PREFIX } from "../constants"
 import { convertUrlStateToAppState, getFiltersForUrl } from "../lib/urlStateUtils"
 import { useGlobalsActions, useFilterActions, useGlobalsInitialFiltersApplied } from "../components/StoreProvider"
+import { isObjectWithKeys } from "../lib/utils"
 
 const searchSchema = z
   .object({
@@ -80,7 +81,7 @@ function RouteComponent() {
    * */
   useLayoutEffect(() => {
     // we only want to apply initial filters only once when url does not contain any filter
-    if (!isUrlRead && Object.keys(activeFilters).length === 0 && Object.keys(initialFilters).length > 0) {
+    if (!isUrlRead && !isObjectWithKeys(activeFilters) && isObjectWithKeys(initialFilters)) {
       setIsUrlRead()
       navigate({
         to: "/alerts",