Skip to content

Commit f7523de

Browse files
committed
chore(heureka): adds a default constant for zero value and changes issue text leftover
1 parent 009a31b commit f7523de

2 files changed

Lines changed: 16 additions & 14 deletions

File tree

apps/heureka/src/components/Vulnerabilities/utils.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import { SELECTED_FILTER_PREFIX } from "../../constants"
77
import { VulnerabilitiesSearchParams } from "../../routes/vulnerabilities"
88
import { IssuesCountsType } from "../types"
99

10+
const DEFAULT_COUNT = 0
11+
1012
export function getActiveVulnerabilityFilter(filterSettings: FilterSettings) {
1113
const filter: any = {}
1214
filterSettings.selectedFilters?.forEach((f: any) => {
@@ -130,7 +132,7 @@ export function getNormalizedVulnerabilitiesResponse(
130132
earliestTargetRemediationDate: edge?.node?.earliestTargetRemediationDate || "",
131133
sourceUrl: edge?.node?.sourceUrl || "",
132134
description: edge?.node?.description || "",
133-
servicesCount: edge?.node?.services?.totalCount || 0,
135+
servicesCount: edge?.node?.services?.totalCount || DEFAULT_COUNT,
134136
services,
135137
supportGroups,
136138
}
@@ -140,16 +142,16 @@ export function getNormalizedVulnerabilitiesResponse(
140142

141143
return {
142144
vulnerabilities,
143-
totalVulnerabilities: counts?.total || 0,
145+
totalVulnerabilities: counts?.total || DEFAULT_COUNT,
144146
pages: data?.Vulnerabilities?.pageInfo?.pages?.filter((edge) => edge !== null) || [],
145147
pageNumber: data?.Vulnerabilities?.pageInfo?.pageNumber || 1,
146148
vulnerabilitiesCounts: {
147-
critical: counts?.critical || 0,
148-
high: counts?.high || 0,
149-
medium: counts?.medium || 0,
150-
low: counts?.low || 0,
151-
none: counts?.none || 0,
152-
total: counts?.total || 0,
149+
critical: counts?.critical || DEFAULT_COUNT,
150+
high: counts?.high || DEFAULT_COUNT,
151+
medium: counts?.medium || DEFAULT_COUNT,
152+
low: counts?.low || DEFAULT_COUNT,
153+
none: counts?.none || DEFAULT_COUNT,
154+
total: counts?.total || DEFAULT_COUNT,
153155
},
154156
}
155157
}

apps/heureka/src/components/common/IssueCountsPerSeverityLevel.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ type IssueCountsPerSeverityLevelProps = {
1414

1515
export const IssueCountsPerSeverityLevel = ({ counts }: IssueCountsPerSeverityLevelProps) => {
1616
if (counts.total === 0) {
17-
return <div>No issues found! 🚀</div>
17+
return <div>No vulnerabilities found! 🚀</div>
1818
}
1919

2020
return (
@@ -27,27 +27,27 @@ export const IssueCountsPerSeverityLevel = ({ counts }: IssueCountsPerSeverityLe
2727
icon="danger"
2828
count={counts.critical}
2929
variant={counts.critical > 0 ? "danger" : "default"}
30-
tooltipContent="Critical Issues"
30+
tooltipContent="Critical Vulnerabilities"
3131
/>
3232
<SeverityCount
3333
icon="warning"
3434
count={counts.high}
3535
variant={counts.high > 0 ? "warning" : "default"}
36-
tooltipContent="High Issues"
36+
tooltipContent="High Vulnerabilities"
3737
/>
3838
<SeverityCount
3939
icon="errorOutline"
4040
count={counts.medium}
4141
variant={counts.medium > 0 ? "warning" : "default"}
42-
tooltipContent="Medium Issues"
42+
tooltipContent="Medium Vulnerabilities"
4343
/>
4444
<SeverityCount
4545
icon="info"
4646
count={counts.low}
4747
variant={counts.low > 0 ? "info" : "default"}
48-
tooltipContent="Low Issues"
48+
tooltipContent="Low Vulnerabilities"
4949
/>
50-
<SeverityCount icon="help" count={counts.none} variant="default" tooltipContent="None Issues" />
50+
<SeverityCount icon="help" count={counts.none} variant="default" tooltipContent="None Vulnerabilities" />
5151
</Stack>
5252
)
5353
}

0 commit comments

Comments
 (0)