fix: Better Go build flags for plugins packaging

erezrokah · erezrokah · commit 295da958efb3 · 2026-02-23T17:37:07.000Z
diff --git a/serve/package.go b/serve/package.go
@@ -130,7 +130,7 @@ func (s *PluginServe) build(pluginDirectory string, target plugin.BuildTarget, d
 		stripSymbols = ""
 	}
 	ldFlags := fmt.Sprintf("%[1]s -w -X %[2]s/plugin.Version=%[3]s -X %[2]s/resources/plugin.Version=%[3]s", stripSymbols, importPath, pluginVersion)
-	args := []string{"build", "-o", pluginPath, "-buildmode=exe", "-ldflags", ldFlags}
+	args := []string{"build", "-trimpath", "-buildvcs=false", "-mod=readonly", "-o", pluginPath, "-buildmode=exe", "-ldflags", ldFlags}
 	cmd := exec.Command("go", args...)
 	cmd.Dir = pluginDirectory
 	cmd.Stdout = os.Stdout

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ func (s *PluginServe) build(pluginDirectory string, target plugin.BuildTarget, d`
`130`	`130`	`stripSymbols = ""`
`131`	`131`	`}`
`132`	`132`	`ldFlags := fmt.Sprintf("%[1]s -w -X %[2]s/plugin.Version=%[3]s -X %[2]s/resources/plugin.Version=%[3]s", stripSymbols, importPath, pluginVersion)`
`133`		`- args := []string{"build", "-o", pluginPath, "-buildmode=exe", "-ldflags", ldFlags}`
	`133`	`+ args := []string{"build", "-trimpath", "-buildvcs=false", "-mod=readonly", "-o", pluginPath, "-buildmode=exe", "-ldflags", ldFlags}`
`134`	`134`	`cmd := exec.Command("go", args...)`
`135`	`135`	`cmd.Dir = pluginDirectory`
`136`	`136`	`cmd.Stdout = os.Stdout`