Skip to content

Commit 519c7f6

Browse files
authored
Merge pull request #11 from cloudscribe/dev
resolve #10, bump version
2 parents 0dfb6ba + 4bf96a0 commit 519c7f6

3 files changed

Lines changed: 14 additions & 38 deletions

File tree

src/cloudscribe.Web.Localization/GlobalResourceManagerStringLocalizer.cs

Lines changed: 11 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,16 @@ public class GlobalResourceManagerStringLocalizer : IStringLocalizer
2121
private readonly ConcurrentDictionary<string, object> _missingManifestCache = new ConcurrentDictionary<string, object>();
2222
private readonly IResourceNamesCache _resourceNamesCache;
2323
private readonly ResourceManager _resourceManager;
24-
private readonly AssemblyWrapper _resourceAssemblyWrapper;
24+
private readonly Assembly _resourceAssembly;
2525
private readonly string _resourceBaseName;
2626

2727
private readonly ResourceManager _globalResourceManager;
2828
private readonly GlobalResourceOptions _globalResourceOptions;
2929

30+
31+
3032
/// <summary>
31-
/// Creates a new <see cref="HybridResourceManagerStringLocalizer"/>.
33+
/// Creates a new <see cref="GlobalResourceManagerStringLocalizer"/>.
3234
/// </summary>
3335
/// <param name="resourceManager">The <see cref="System.Resources.ResourceManager"/> to read strings from.</param>
3436
/// <param name="resourceAssembly">The <see cref="Assembly"/> that contains the strings as embedded resources.</param>
@@ -44,41 +46,15 @@ public GlobalResourceManagerStringLocalizer(
4446
GlobalResourceOptions globalResourceOptions,
4547
ResourceManager globalResourceManager = null
4648
)
47-
: this(
48-
resourceManager,
49-
new AssemblyWrapper(resourceAssembly),
50-
baseName,
51-
resourceNamesCache,
52-
globalResourceOptions,
53-
globalResourceManager
54-
)
55-
{
56-
if (resourceAssembly == null)
57-
{
58-
throw new ArgumentNullException(nameof(resourceAssembly));
59-
}
60-
}
61-
62-
/// <summary>
63-
/// Intended for testing purposes only.
64-
/// </summary>
65-
public GlobalResourceManagerStringLocalizer(
66-
ResourceManager resourceManager,
67-
AssemblyWrapper resourceAssemblyWrapper,
68-
string baseName,
69-
IResourceNamesCache resourceNamesCache,
70-
GlobalResourceOptions globalResourceOptions,
71-
ResourceManager globalResourceManager = null
72-
)
7349
{
7450
if (resourceManager == null)
7551
{
7652
throw new ArgumentNullException(nameof(resourceManager));
7753
}
7854

79-
if (resourceAssemblyWrapper == null)
55+
if (resourceAssembly == null)
8056
{
81-
throw new ArgumentNullException(nameof(resourceAssemblyWrapper));
57+
throw new ArgumentNullException(nameof(resourceAssembly));
8258
}
8359

8460
if (baseName == null)
@@ -91,7 +67,7 @@ public GlobalResourceManagerStringLocalizer(
9167
throw new ArgumentNullException(nameof(resourceNamesCache));
9268
}
9369

94-
_resourceAssemblyWrapper = resourceAssemblyWrapper;
70+
_resourceAssembly = resourceAssembly;
9571
_resourceManager = resourceManager;
9672
_resourceBaseName = baseName;
9773
_resourceNamesCache = resourceNamesCache;
@@ -143,15 +119,15 @@ public IStringLocalizer WithCulture(CultureInfo culture)
143119
return culture == null
144120
? new GlobalResourceManagerStringLocalizer(
145121
_resourceManager,
146-
_resourceAssemblyWrapper.Assembly,
122+
_resourceAssembly,
147123
_resourceBaseName,
148124
_resourceNamesCache,
149125
_globalResourceOptions,
150126
_globalResourceManager
151127
)
152128
: new GlobalResourceManagerWithCultureStringLocalizer(
153129
_resourceManager,
154-
_resourceAssemblyWrapper.Assembly,
130+
_resourceAssembly,
155131
_resourceBaseName,
156132
_resourceNamesCache,
157133
culture,
@@ -307,11 +283,11 @@ private IList<string> GetResourceNamesForCulture(CultureInfo culture)
307283
{
308284
var resourceStreamName = GetResourceStreamName(culture);
309285

310-
var cacheKey = $"assembly={_resourceAssemblyWrapper.FullName};resourceStreamName={resourceStreamName}";
286+
var cacheKey = $"assembly={_resourceAssembly.FullName};resourceStreamName={resourceStreamName}";
311287

312288
var cultureResourceNames = _resourceNamesCache.GetOrAdd(cacheKey, _ =>
313289
{
314-
using (var cultureResourceStream = _resourceAssemblyWrapper.GetManifestResourceStream(resourceStreamName))
290+
using (var cultureResourceStream = _resourceAssembly.GetManifestResourceStream(resourceStreamName))
315291
{
316292
if (cultureResourceStream == null)
317293
{

src/cloudscribe.Web.Localization/GlobalResourceManagerStringLocalizerFactory.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public class GlobalResourceManagerStringLocalizerFactory : IStringLocalizerFacto
2121
private readonly IResourceNamesCache _resourceNamesCache = new ResourceNamesCache();
2222
private readonly ConcurrentDictionary<string, GlobalResourceManagerStringLocalizer> _localizerCache =
2323
new ConcurrentDictionary<string, GlobalResourceManagerStringLocalizer>();
24-
private readonly IHostingEnvironment _hostingEnvironment;
24+
private readonly IWebHostEnvironment _hostingEnvironment;
2525
private readonly string _resourcesRelativePath;
2626
private readonly GlobalResourceOptions globalResourceOptions;
2727

@@ -31,7 +31,7 @@ public class GlobalResourceManagerStringLocalizerFactory : IStringLocalizerFacto
3131
/// <param name="hostingEnvironment">The <see cref="IHostingEnvironment"/>.</param>
3232
/// <param name="localizationOptions">The <see cref="IOptions{LocalizationOptions}"/>.</param>
3333
public GlobalResourceManagerStringLocalizerFactory(
34-
IHostingEnvironment hostingEnvironment,
34+
IWebHostEnvironment hostingEnvironment,
3535
IOptions<LocalizationOptions> localizationOptions,
3636
IOptions<GlobalResourceOptions> globalResourceOptionsAccessor
3737
)

src/cloudscribe.Web.Localization/cloudscribe.Web.Localization.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<Description>more flexible localization for ASP.NET Core</Description>
5-
<Version>3.0.2</Version>
5+
<Version>3.0.3</Version>
66
<Authors>Joe Audette</Authors>
77
<TargetFrameworks>netcoreapp3.0</TargetFrameworks>
88
<PackageId>cloudscribe.Web.Localization</PackageId>

0 commit comments

Comments
 (0)