Add more tests for retention policies

Author: sebastian-ederer

tests/Eftdb.Tests/Generators/RetentionPolicyOperationGeneratorTests.cs

@@ -400,6 +400,118 @@ FROM timescaledb_information.jobs
 
         #endregion
 
+        #region Generate_Alter_DropCreatedBefore_job_settings_change_skips_alter_job
+
+        [Fact]
+        public void Generate_Alter_DropCreatedBefore_job_settings_change_skips_alter_job()
+        {
+            // Arrange
+            AlterRetentionPolicyOperation operation = new()
+            {
+                Schema = "public",
+                TableName = "TestTable",
+                DropAfter = null,
+                OldDropAfter = null,
+                DropCreatedBefore = "30 days",
+                OldDropCreatedBefore = "30 days",
+                InitialStart = null,
+                OldInitialStart = null,
+                ScheduleInterval = "2 days",          // <-- Changed from "1 day"
+                OldScheduleInterval = "1 day"
+            };
+
+            // No recreation needed, but alter_job is skipped for DropCreatedBefore due to TimescaleDB bug #9446.
+            RetentionPolicyOperationGenerator generator = new(true);
+            List<string> result = generator.Generate(operation);
+
+            // Assert
+            Assert.Empty(result);
+        }
+
+        #endregion
+
+        #region Generate_Alter_MaxRuntime_change_emits_alter_job
+
+        [Fact]
+        public void Generate_Alter_MaxRuntime_change_emits_alter_job()
+        {
+            // Arrange
+            AlterRetentionPolicyOperation operation = new()
+            {
+                Schema = "public",
+                TableName = "TestTable",
+                DropAfter = "7 days",
+                OldDropAfter = "7 days",
+                DropCreatedBefore = null,
+                OldDropCreatedBefore = null,
+                InitialStart = null,
+                OldInitialStart = null,
+                MaxRuntime = "2 hours",               // <-- Changed from "1 hour"
+                OldMaxRuntime = "1 hour",
+                ScheduleInterval = "1 day",
+                OldScheduleInterval = "1 day",
+                MaxRetries = -1,
+                OldMaxRetries = -1,
+                RetryPeriod = "1 day",
+                OldRetryPeriod = "1 day"
+            };
+
+            string expected = @".Sql(@""
+                SELECT alter_job(job_id, max_runtime => INTERVAL '2 hours')
+                FROM timescaledb_information.jobs
+                WHERE proc_name = 'policy_retention' AND hypertable_schema = 'public' AND hypertable_name = 'TestTable';
+            "")";
+
+            // Act
+            string result = GetGeneratedCode(operation);
+
+            // Assert
+            Assert.Equal(SqlHelper.NormalizeSql(expected), SqlHelper.NormalizeSql(result));
+        }
+
+        #endregion
+
+        #region Generate_Alter_RetryPeriod_change_emits_alter_job
+
+        [Fact]
+        public void Generate_Alter_RetryPeriod_change_emits_alter_job()
+        {
+            // Arrange
+            AlterRetentionPolicyOperation operation = new()
+            {
+                Schema = "public",
+                TableName = "TestTable",
+                DropAfter = "7 days",
+                OldDropAfter = "7 days",
+                DropCreatedBefore = null,
+                OldDropCreatedBefore = null,
+                InitialStart = null,
+                OldInitialStart = null,
+                ScheduleInterval = "1 day",
+                OldScheduleInterval = "1 day",
+                MaxRuntime = "00:00:00",
+                OldMaxRuntime = "00:00:00",
+                MaxRetries = -1,
+                OldMaxRetries = -1,
+                RetryPeriod = "30 minutes",           // <-- Changed from "1 day"
+                OldRetryPeriod = "1 day"
+            };
+
+            string expected = @".Sql(@""
+                SELECT alter_job(job_id, retry_period => INTERVAL '30 minutes')
+                FROM timescaledb_information.jobs
+                WHERE proc_name = 'policy_retention' AND hypertable_schema = 'public' AND hypertable_name = 'TestTable';
+            "")";
+
+            // Act
+            string result = GetGeneratedCode(operation);
+
+            // Assert
+            Assert.Equal(SqlHelper.NormalizeSql(expected), SqlHelper.NormalizeSql(result));
+        }
+
+        #endregion
+
         // --- Tests for runtime quoting (isDesignTime=false) ---
 
         private static List<string> GetRuntimeStatements(dynamic operation)

tests/Eftdb.Tests/Integration/MigrationOperationOrderingTests.cs

@@ -1,5 +1,6 @@
 using CmdScale.EntityFrameworkCore.TimescaleDB.Configuration.Hypertable;
 using CmdScale.EntityFrameworkCore.TimescaleDB.Configuration.ReorderPolicy;
+using CmdScale.EntityFrameworkCore.TimescaleDB.Configuration.RetentionPolicy;
 using CmdScale.EntityFrameworkCore.TimescaleDB.Operations;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.EntityFrameworkCore.Migrations.Operations;
@@ -726,6 +727,68 @@ public void Should_Order_Hypertable_And_Indexes_Correctly()
 
     #endregion
 
+    #region Should_Order_CreateHypertable_Before_AddRetentionPolicy
+
+    private class OrderingMetric9
+    {
+        public DateTime Timestamp { get; set; }
+        public double Value { get; set; }
+    }
+
+    private class OrderingContext9 : DbContext
+    {
+        public DbSet<OrderingMetric9> Metrics => Set<OrderingMetric9>();
+
+        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
+            => optionsBuilder.UseNpgsql("Host=localhost;Database=test;Username=test;Password=test")
+                            .UseTimescaleDb();
+
+        protected override void OnModelCreating(ModelBuilder modelBuilder)
+        {
+            modelBuilder.Entity<OrderingMetric9>(entity =>
+            {
+                entity.ToTable("OrderingMetrics9");
+                entity.HasNoKey();
+                entity.IsHypertable(x => x.Timestamp)
+                      .WithChunkTimeInterval("1 day");
+                entity.WithRetentionPolicy(dropAfter: "30 days");
+            });
+        }
+    }
+
+    /// <summary>
+    /// Verifies that CreateHypertableOperation appears before AddRetentionPolicyOperation.
+    /// Retention policies require the hypertable to exist first.
+    /// </summary>
+    [Fact]
+    public void Should_Order_CreateHypertable_Before_AddRetentionPolicy()
+    {
+        // Arrange
+        using OrderingContext9 context = new();
+
+        // Act
+        IReadOnlyList<MigrationOperation> operations = GenerateMigrationOperations(null, context);
+
+        // Assert
+        int createTableIndex = operations.ToList().FindIndex(op =>
+            op is CreateTableOperation createTable && createTable.Name == "OrderingMetrics9");
+        int hypertableIndex = operations.ToList().FindIndex(op =>
+            op is CreateHypertableOperation hypertable && hypertable.TableName == "OrderingMetrics9");
+        int retentionPolicyIndex = operations.ToList().FindIndex(op =>
+            op is AddRetentionPolicyOperation policy && policy.TableName == "OrderingMetrics9");
+
+        Assert.NotEqual(-1, createTableIndex);
+        Assert.NotEqual(-1, hypertableIndex);
+        Assert.NotEqual(-1, retentionPolicyIndex);
+
+        Assert.True(createTableIndex < hypertableIndex,
+            $"CreateTable (index {createTableIndex}) should appear before CreateHypertable (index {hypertableIndex})");
+        Assert.True(hypertableIndex < retentionPolicyIndex,
+            $"CreateHypertable (index {hypertableIndex}) should appear before AddRetentionPolicy (index {retentionPolicyIndex})");
+    }
+
+    #endregion
+
     #region Should_Fail_With_Unstable_Sort_Many_Tables
 
     // Many entity classes to generate enough operations to trigger unstable sort behavior