defaultStageDisplayName verwijderd

Author: Cliff Odijk

.projenrc.ts

@@ -106,11 +106,6 @@ const project = new GitHubActionTypeScriptProject({
         required: false,
         default: 'change-set',
       },
-      defaultStageDisplayName: {
-        description: 'An optional display name for the CDK default stage.',
-        required: false,
-        default: 'DefaultStage',
-      },
       title: {
         description: 'An optional title for each diff comment on the PR.',
         required: false,

action.yml

@@ -97,9 +97,6 @@ export async function run() {
 
   const inputs: Inputs = {
     title: getInput('title') || undefined,
-    defaultStageDisplayName: getInput('defaultStageDisplayName', {
-      required: true,
-    }),
     githubToken: getInput('githubToken'),
     stackSelectorPatterns: getMultilineInput('stackSelectorPatterns'),
     stackSelectionStrategy: getInput('stackSelectionStrategy', {

dist/index.js

@@ -7,7 +7,6 @@ export interface Inputs {
    */
   githubToken: string;
 
-
   /**
    * List of stack selector patterns
    *
@@ -48,13 +47,6 @@ export interface Inputs {
    */
   baseRef: string;
 
-  /**
-   * An optional display name for the CDK default stage.
-   *
-   * @default DefaultStage
-   */
-  defaultStageDisplayName: string;
-
   /**
    * An optional title for each diff comment on the PR.
    *

dist/index.js.map

@@ -48,7 +48,6 @@ export interface AssemblyProcessorOptions
   cdkOutDir: string;
   diffMethod: DiffMethod;
   toolkit: Toolkit;
-  defaultStageDisplayName: string;
 }
 
 /**
@@ -80,7 +79,7 @@ export class AssemblyProcessor {
     this._stageInfo = assembly.stages;
     if (assembly.stacks.length) {
       this.stageInfo.push({
-        name: this.options.defaultStageDisplayName,
+        name: 'DefaultStage',
         stacks: assembly.stacks,
       });
     }

src/action.ts

@@ -111,7 +111,6 @@ describe('StageProcessor', () => {
       node_modules: mock.load(path.join(__dirname, '..', 'node_modules')),
     });
     const processor = new AssemblyProcessor({
-      defaultStageDisplayName: 'DefaultStage',
       toolkit,
       allowedDestroyTypes: [],
       cdkOutDir: 'cdk.out',
@@ -149,7 +148,6 @@ describe('StageProcessor', () => {
       node_modules: mock.load(path.join(__dirname, '..', 'node_modules')),
     });
     const processor = new AssemblyProcessor({
-      defaultStageDisplayName: 'DefaultStage',
       toolkit,
       allowedDestroyTypes: [],
       cdkOutDir: 'cdk.out',
@@ -187,7 +185,6 @@ describe('StageProcessor', () => {
       node_modules: mock.load(path.join(__dirname, '..', 'node_modules')),
     });
     const processor = new AssemblyProcessor({
-      defaultStageDisplayName: 'DefaultStage',
       toolkit,
       allowedDestroyTypes: [],
       cdkOutDir: 'cdk.out',
@@ -226,7 +223,6 @@ describe('StageProcessor', () => {
       node_modules: mock.load(path.join(__dirname, '..', 'node_modules')),
     });
     const processor = new AssemblyProcessor({
-      defaultStageDisplayName: 'DefaultStage',
       toolkit,
       allowedDestroyTypes: [],
       cdkOutDir: 'cdk.out',
@@ -261,7 +257,6 @@ describe('StageProcessor', () => {
       node_modules: mock.load(path.join(__dirname, '..', 'node_modules')),
     });
     const processor = new AssemblyProcessor({
-      defaultStageDisplayName: 'DefaultStage',
       toolkit,
       allowedDestroyTypes: [],
       cdkOutDir: 'cdk.out',
@@ -372,7 +367,6 @@ describe('StageProcessor', () => {
       node_modules: mock.load(path.join(__dirname, '..', 'node_modules')),
     });
     const processor = new AssemblyProcessor({
-      defaultStageDisplayName: 'DefaultStage',
       toolkit,
       allowedDestroyTypes: [],
       cdkOutDir: 'cdk.out',
@@ -446,7 +440,6 @@ describe('default stage', () => {
       node_modules: mock.load(path.join(__dirname, '..', 'node_modules')),
     });
     const processor = new AssemblyProcessor({
-      defaultStageDisplayName: 'DefaultStage',
       toolkit,
       allowedDestroyTypes: [],
       cdkOutDir: 'cdk.out',
@@ -467,36 +460,6 @@ describe('default stage', () => {
       'No Changes for stack: test-stack :white_check_mark:',
     ]);
   });
-
-  test('with custom', async () => {
-    mock({
-      'cdk.out': mockOutDir,
-      node_modules: mock.load(path.join(__dirname, '..', 'node_modules')),
-    });
-    const processor = new AssemblyProcessor({
-      defaultStageDisplayName: 'MyStage',
-      title: 'Diff for MyStage',
-      toolkit,
-      allowedDestroyTypes: [],
-      cdkOutDir: 'cdk.out',
-      diffMethod: DiffMethod.LocalFile(
-        'cdk.out/SomeStage-test-stack.template.json',
-      ),
-      failOnDestructiveChanges: true,
-      stackSelectorPatterns: [],
-      stackSelectionStrategy: 'all-stacks',
-      noFailOnDestructiveChanges: [],
-    });
-    await processor.processStages();
-    const p = processor.stageComments;
-    expect(p).toEqual({
-      MyStage: expect.any(Object),
-    });
-    expect(p.MyStage.title).toEqual('Diff for MyStage');
-    expect(p.MyStage.stackComments['test-stack']).toEqual([
-      'No Changes for stack: test-stack :white_check_mark:',
-    ]);
-  });
 });
 
 function setupCommentTest(): AssemblyProcessor {
@@ -536,7 +499,6 @@ function setupCommentTest(): AssemblyProcessor {
   });
   jest.spyOn(Toolkit.prototype, 'diff').mockResolvedValue(templateDiff);
   return new AssemblyProcessor({
-    defaultStageDisplayName: 'DefaultStage',
     toolkit,
     allowedDestroyTypes: [],
     cdkOutDir: 'cdk.out',