From 71fa071dbff9381529aec24d9f25086689be383b Mon Sep 17 00:00:00 2001 From: Andrew Karpow Date: Wed, 8 Apr 2026 13:24:05 -0400 Subject: [PATCH] EvictionController: Fix potential panic on header access Use Header.Get() instead of direct array indexing to safely access X-Openstack-Request-Id header. This prevents panic if the header is missing or empty. --- internal/controller/eviction_controller.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/controller/eviction_controller.go b/internal/controller/eviction_controller.go index b8fc678..cd0dd9e 100644 --- a/internal/controller/eviction_controller.go +++ b/internal/controller/eviction_controller.go @@ -368,7 +368,7 @@ func (r *EvictionReconciler) liveMigrate(ctx context.Context, uuid string, evict return err } - log.Info("Live migrating server", "server", uuid, "source", eviction.Spec.Hypervisor, "X-Openstack-Request-Id", res.Header["X-Openstack-Request-Id"][0]) + log.Info("Live migrating server", "server", uuid, "source", eviction.Spec.Hypervisor, "X-Openstack-Request-Id", res.Header.Get("X-Openstack-Request-Id")) return nil } @@ -387,7 +387,7 @@ func (r *EvictionReconciler) coldMigrate(ctx context.Context, uuid string, evict return err } - log.Info("Cold-migrating server", "server", uuid, "source", eviction.Spec.Hypervisor, "X-Openstack-Request-Id", res.Header["X-Openstack-Request-Id"][0]) + log.Info("Cold-migrating server", "server", uuid, "source", eviction.Spec.Hypervisor, "X-Openstack-Request-Id", res.Header.Get("X-Openstack-Request-Id")) return nil }