Rename + split in 2 tests

Author: aguingand

docs/guide/building-entity-list.md

@@ -54,7 +54,7 @@ The optional `->setWidth()` method accepts either an integer (eg: `20` for 20%),
 To hide the column on small screens, use `->hideOnSmallScreens()`.
 
 ::: warning
-HTML sanitization is enabled by default for list fields (to prevent XSS attacks when displaying the list). You can disable it by using `->shouldSanitizeHtml(false)` field method.
+HTML sanitization is enabled by default for list fields (to prevent XSS attacks when displaying the list). You can disable it by using `->setSanitizeHtml(false)` field method.
 :::
 
 Sorting columns must be handled in the `getListData()` method, see below.

docs/guide/form-fields/editor.md

@@ -95,7 +95,7 @@ Unset the max character count.
 
 Display a character count in the status bar. Default is false.
 
-### `shouldSanitizeHtml(bool $sanitize = true)`
+### `setSanitizeHtml(bool $sanitizeHtml = true)`
 
 Toggle HTML sanitization (enabled by default). See [security](#security).
 
@@ -255,7 +255,7 @@ The [documentation on how to write an Embed class is available here](../form-edi
 
 ## Security
 
-Editor content is sanitized by default before storing the data (to prevent XSS attack when displaying HTML content). To disable sanitizing you can call `->shouldSanitizeHtml(false)`.
+Editor content is sanitized by default before storing the data (to prevent XSS attack when displaying HTML content). To disable sanitizing you can call `->setSanitizeHtml(false)`.
 
 ## Formatter
 

docs/guide/form-fields/text.md

@@ -32,7 +32,7 @@ Set a max character count.
 
 Unset the max character count.
 
-### `shouldSanitizeHtml()`
+### `setSanitizeHtml()`
 
 Enable HTML sanitization (to prevent XSS attacks if this field data is used as raw HTML).
 

docs/guide/form-fields/textarea.md

@@ -16,7 +16,7 @@ Set a max character count.
 
 Unset the max character count.
 
-### `shouldSanitizeHtml()`
+### `setSanitizeHtml()`
 
 Enable HTML sanitization (to prevent XSS attacks if this field data is used as raw HTML).
 

docs/guide/show-fields/text.md

@@ -20,9 +20,9 @@ Reset the collapse configuration.
 
 By default, the text is escaped. If you want to display HTML, set this to true.
 
-### `shouldSanitizeHtml(bool $sanitize = true)`
+### `setSanitizeHtml(bool $sanitizeHtml = true)`
 
-HTML sanitization is enabled by default for text fields (to prevent XSS attacks when displaying the show). To disable it, call `->shouldSanitizeHtml(false)`.
+HTML sanitization is enabled by default for text fields (to prevent XSS attacks when displaying the show). To disable it, call `->setSanitizeHtml(false)`.
 
 
 ### `allowEmbeds(array $embeds)`

src/EntityList/Fields/EntityListField.php

@@ -16,7 +16,7 @@ class EntityListField implements Arrayable, IsEntityListField, IsSharpFieldWithH
     private function __construct(string $key)
     {
         $this->key = $key;
-        $this->sanitize = true;
+        $this->sanitizeHtml = true;
     }
 
     public static function make(string $key): self
@@ -55,7 +55,7 @@ public function toArray(): array
             'label' => $this->label,
             'sortable' => $this->sortable,
             'html' => $this->html,
-            'sanitize' => $this->sanitize,
+            'sanitize' => $this->sanitizeHtml,
             'width' => $this->width,
             'hideOnXS' => $this->hideOnXs,
         ];

src/Form/Fields/SharpFormEditorField.php

@@ -69,7 +69,7 @@ class SharpFormEditorField extends SharpFormField implements IsSharpFieldWithEmb
     protected function __construct(string $key, string $type, ?SharpFieldFormatter $formatter = null)
     {
         parent::__construct($key, $type, $formatter);
-        $this->sanitize = true;
+        $this->sanitizeHtml = true;
     }
 
     public static function make(string $key): self

src/Show/Fields/SharpShowTextField.php

@@ -26,7 +26,7 @@ class SharpShowTextField extends SharpShowField implements IsSharpFieldWithEmbed
     protected function __construct(string $key, string $type, ?SharpShowFieldFormatter $formatter = null)
     {
         parent::__construct($key, $type, $formatter);
-        $this->sanitize = true;
+        $this->sanitizeHtml = true;
     }
 
     public static function make(string $key): SharpShowTextField
@@ -67,7 +67,7 @@ public function toArray(): array
         return parent::buildArray([
             'label' => $this->label,
             'html' => $this->html,
-            'sanitize' => $this->sanitize,
+            'sanitize' => $this->sanitizeHtml,
             'collapseToWordCount' => $this->collapseToWordCount,
             'localized' => $this->localized,
             'embeds' => $this->innerComponentEmbedsConfiguration(false) ?: null,

src/Utils/Sanitization/SharpFieldWithHtmlSanitization.php

@@ -4,11 +4,11 @@
 
 trait SharpFieldWithHtmlSanitization
 {
-    protected bool $sanitize = false;
+    protected bool $sanitizeHtml = false;
 
-    public function shouldSanitizeHtml(bool $sanitize = true): self
+    public function setSanitizeHtml(bool $sanitizeHtml = true): self
     {
-        $this->sanitize = $sanitize;
+        $this->sanitizeHtml = $sanitizeHtml;
 
         return $this;
     }
@@ -18,6 +18,6 @@ public function shouldSanitizeHtml(bool $sanitize = true): self
      */
     public function isSanitizingHtml(): bool
     {
-        return $this->sanitize;
+        return $this->sanitizeHtml;
     }
 }

tests/Unit/EntityList/SharpEntityListTest.php

@@ -375,7 +375,7 @@ public function buildList(EntityListFieldsContainer $fields): void
             $fields->addField(
                 EntityListField::make('name')
                     ->setLabel('Name')
-                    ->shouldSanitizeHtml(false)
+                    ->setSanitizeHtml(false)
                     ->setWidth(.5)
             );
         }