Fix 0 passed to multiple select filter

Author: aguingand

src/Filters/FilterContainer/FilterContainer.php

@@ -102,7 +102,6 @@ public function getDefaultFilterValues(): Collection
             ])
             ->mapWithKeys(function (Filter $handler) {
                 return [
-                    // we pass through fromQueryParam() & toQueryParam() to ensure the value is formatted correctly
                     $handler->getKey() => $handler->toQueryParam($handler->defaultValue()),
                 ];
             });

src/Filters/SelectMultipleFilter.php

@@ -2,17 +2,19 @@
 
 namespace Code16\Sharp\Filters;
 
-use Illuminate\Support\Arr;
-
 abstract class SelectMultipleFilter extends SelectFilter
 {
     public function fromQueryParam($value): array
     {
-        return $value ? explode(',', $value) : [];
+        return $value !== null
+            ? explode(',', $value)
+            : [];
     }
 
     public function toQueryParam($value): ?string
     {
-        return $value ? implode(',', Arr::wrap($value)) : null;
+        return $value && count($value)
+            ? collect($value)->implode(',')
+            : null;
     }
 }

tests/Http/FiltersInRequestTest.php

@@ -132,6 +132,7 @@ public function buildFilterConfig(): void
                     public function values(): array
                     {
                         return [
+                            '0' => 'Void',
                             'physicist' => 'Physicist',
                             'physician' => 'Physician',
                         ];
@@ -145,6 +146,7 @@ public function getListData(): array|Arrayable
             return collect([
                 ['id' => 1, 'name' => 'Marie Curie', 'job' => 'physicist'],
                 ['id' => 2, 'name' => 'Louis Pasteur', 'job' => 'physician'],
+                ['id' => 3, 'name' => 'John Void', 'job' => '0'],
             ])
                 ->filter(fn ($item) => in_array($item['job'], $this->queryParams->filterFor('job')))
                 ->values();
@@ -167,6 +169,18 @@ public function getListData(): array|Arrayable
             )
             ->count('entityList.data', 2)
         );
+
+    $this
+        ->get('/sharp/s-list/person?filter_job=0')
+        ->assertOk()
+        ->assertInertia(fn (Assert $page) => $page
+            ->has('entityList.data.0', fn (Assert $json) => $json
+                ->where('id', 3)
+                ->where('name', 'John Void')
+                ->etc()
+            )
+            ->count('entityList.data', 1)
+        );
 });
 
 it('saves retained filters in the session when set', function () {