fix multiform when no parent entity form provided

Author: aguingand

src/Http/Controllers/HandlesEntityListItems.php

@@ -34,7 +34,7 @@ private function addMetaToItems(array $listItems, string $entityKey, SharpEntity
             ->all();
     }
 
-    private function getItemEntityKey(array $item, string $entityKey, SharpEntity $entity, SharpEntityList $list): string
+    private function getItemEntityKey(array $item, string $entityKey, SharpEntity $entity, SharpEntityList $list): EntityKey
     {
         $itemEntityAttributeValue = $list->getEntityAttribute()
             ? ($item[$list->getEntityAttribute()] ?? null)
@@ -51,10 +51,10 @@ private function getItemEntityKey(array $item, string $entityKey, SharpEntity $e
                 );
             }
 
-            return $listEntity->getEntityKey();
+            return new EntityKey($listEntity->getEntityKey());
         }
 
-        return $entityKey;
+        return new EntityKey($entityKey);
     }
 
     private function getItemUrl(array $item, string $entityKey, SharpEntity $entity, SharpEntityList $list): ?string
@@ -77,7 +77,10 @@ private function getItemUrl(array $item, string $entityKey, SharpEntity $entity,
                     'entityKey' => $itemEntityKey,
                     'instanceId' => $item[$list->getInstanceIdAttribute()],
                 ]);
-            } elseif ($itemEntity->hasForm()) {
+            }
+            if ($itemEntity->hasForm()
+                || $itemEntityKey->multiformKey() && isset($entity->getMultiforms()[$itemEntityKey->multiformKey()])
+            ) {
                 return route('code16.sharp.form.edit', [
                     'parentUri' => $breadcrumb->getCurrentPath(),
                     'entityKey' => $itemEntityKey,

tests/Fixtures/Entities/PersonEntity.php

@@ -47,6 +47,10 @@ public function setShow(?SharpShow $show): self
     public function setForm(?SharpForm $form): self
     {
         $this->fakeForm = $form;
+        if ($form === null) {
+            // Enforce show to be null
+            $this->form = null;
+        }
 
         return $this;
     }

tests/Http/EntityListControllerTest.php

@@ -455,6 +455,72 @@ public function buildListConfig(): void
                 ->where('key', 'nope')
                 ->where('entityKey', 'person:nope')
                 ->where('label', 'No Nobel prize')
+
+                ->etc()
+            )
+            ->has('entityList.data.0', fn (Assert $json) => $json
+                ->where('_meta.url', route('code16.sharp.show.show', ['parentUri' => 's-list/person', 'entityKey' => 'person:yes', 'instanceId' => 1]))
+                ->etc()
+            )
+            ->has('entityList.data.1', fn (Assert $json) => $json
+                ->where('_meta.url', route('code16.sharp.show.show', ['parentUri' => 's-list/person', 'entityKey' => 'person:nope', 'instanceId' => 2]))
+                ->etc()
+            )
+        );
+});
+
+it('gets multiform form url if configured', function () {
+    $this->withoutExceptionHandling();
+    fakeListFor('person', new class() extends PersonList
+    {
+        public function getListData(): array|Arrayable
+        {
+            return [
+                ['id' => 1, 'name' => 'Marie Curie', 'nobel' => 'yes'],
+                ['id' => 2, 'name' => 'Rosalind Franklin', 'nobel' => 'nope'],
+            ];
+        }
+
+        public function buildListConfig(): void
+        {
+            $this->configureMultiformAttribute('nobel');
+        }
+    });
+
+    app(SharpEntityManager::class)
+        ->entityFor('person')
+        ->setShow(null)
+        ->setMultiforms([
+            'yes' => [PersonForm::class, 'With Nobel prize'],
+            'nope' => [PersonForm::class, 'No Nobel prize'],
+        ]);
+
+    $this->get('/sharp/s-list/person')
+        ->assertOk()
+        ->assertInertia(fn (Assert $page) => $page
+            ->has('entityList.data.0', fn (Assert $json) => $json
+                ->where('_meta.url', route('code16.sharp.form.edit', ['parentUri' => 's-list/person', 'entityKey' => 'person:yes', 'instanceId' => 1]))
+                ->etc()
+            )
+            ->has('entityList.data.1', fn (Assert $json) => $json
+                ->where('_meta.url', route('code16.sharp.form.edit', ['parentUri' => 's-list/person', 'entityKey' => 'person:nope', 'instanceId' => 2]))
+                ->etc()
+            )
+        );
+
+    app(SharpEntityManager::class)
+        ->entityFor('person')
+        ->setForm(null);
+
+    $this->get('/sharp/s-list/person')
+        ->assertOk()
+        ->assertInertia(fn (Assert $page) => $page
+            ->has('entityList.data.0', fn (Assert $json) => $json
+                ->where('_meta.url', route('code16.sharp.form.edit', ['parentUri' => 's-list/person', 'entityKey' => 'person:yes', 'instanceId' => 1]))
+                ->etc()
+            )
+            ->has('entityList.data.1', fn (Assert $json) => $json
+                ->where('_meta.url', route('code16.sharp.form.edit', ['parentUri' => 's-list/person', 'entityKey' => 'person:nope', 'instanceId' => 2]))
                 ->etc()
             )
         );